Jenkins-kde-ci: kcmutils master stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

2015-09-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Sep 2015 06:57:29 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kcmutils master stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

2015-09-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Sep 2015 06:57:29 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 79 - Unstable!

2015-09-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Sep 2015 20:19:53 + Build duration: 11 min CHANGE SET Revision 2f8ca0ef86e29ad3465e54be7ae0c111310469d0

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 86 - Unstable!

2015-09-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Sep 2015 20:19:53 + Build duration: 5 min 47 sec CHANGE SET Revision 2f8ca0ef86e29ad3465e54be7ae

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 30 - Unstable!

2015-09-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Sep 2015 20:09:22 + Build duration: 3 min 35 sec CHANGE SET Revision 5c287d1ca097c9b57998a6fc6f

Re: Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-04 Thread Jean-Baptiste Mardelle
> On Sept. 4, 2015, 8:59 p.m., David Faure wrote: > > path() is wrong for local files on Windows, it should be toLocalFile() > > instead. > > > > If the use of local paths should depend on the mode, like in your patch, > > then just use toLocalFile() instead of path(). > > If the use of local

Re: Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-04 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/ --- (Updated Sept. 4, 2015, 9:32 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kcmutils master stable-kf5-qt5 » Linux,gcc - Build # 12 - Failure!

2015-09-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcmutils%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Sep 2015 20:07:02 + Build duration: 20 min CHANGE SET Revision e65535cb0f05e1468e7f56447aca62767d687

Re: Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/#review84856 --- path() is wrong for local files on Windows, it should be toLoc

Re: Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-04 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/ --- (Updated Sept. 4, 2015, 8:29 p.m.) Review request for KDE Frameworks and

Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-04 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/ --- Review request for KDE Frameworks and David Faure. Bugs: 350696 https

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/ --- (Updated Sept. 4, 2015, 8:08 p.m.) Status -- This change has been ma

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/ --- (Updated Sept. 4, 2015, 10:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Emmanuel Pescosta
> On Sept. 4, 2015, 3:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. > > Luca Beltrame wrote: > I applied the patch locally, fixes also the aforementioned bug. > > Luca Beltrame wrote: > It just occurred to me that k

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Ivan Čukić
> On Sept. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. > > Luca Beltrame wrote: > I applied the patch locally, fixes also the aforementioned bug. > > Luca Beltrame wrote: > It just occurred to me that k

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84842 --- Ship it! Ship It! - Ivan Čukić On Sept. 4, 2015, 1:01 p.m.

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-04 Thread Burkhard Lück
> On Sept. 4, 2015, 2:56 nachm., David Faure wrote: > > Wasn't the reason for desktop files that we have infrastructure for > > translating desktop files but not json files? > > > > (I could be wrong, of course). > > Alex Richardson wrote: > I thought this has now been fixed and JSON files

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-04 Thread Alex Richardson
> On Sept. 4, 2015, 3:56 p.m., David Faure wrote: > > Wasn't the reason for desktop files that we have infrastructure for > > translating desktop files but not json files? > > > > (I could be wrong, of course). > > Alex Richardson wrote: > I thought this has now been fixed and JSON files a

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-04 Thread Alex Richardson
> On Sept. 4, 2015, 3:56 p.m., David Faure wrote: > > Wasn't the reason for desktop files that we have infrastructure for > > translating desktop files but not json files? > > > > (I could be wrong, of course). I thought this has now been fixed and JSON files are also translated. - Alex --

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review84831 --- Wasn't the reason for desktop files that we have infrastructur

Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-04 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. > > Luca Beltrame wrote: > I applied the patch locally, fixes also the aforementioned bug. It just occurred to me that kactivities does not use RB for p

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. I applied the patch locally, fixes also the aforementioned bug. - Luca --- This is an automatical

Re: assert in kservicetypefactory.cpp

2015-09-04 Thread Boudewijn Rempt
On Tue, 1 Sep 2015, David Faure wrote: On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: Oh. I think you found a real bug :-) Does this patch help? Hm, doesn't look like it... How about the current kservice code, where I completely got rid of the kded dependency? Does that fix the

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84820 --- Can you check whether it also fixes bug 351585? To me the issu

Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/ --- Review request for KDE Frameworks and Ivan Čukić. Bugs: 352207 http:/

KSelectionProxyModel problem

2015-09-04 Thread Ilya Matveychikov
Here is the KSelectionProxyModel model ​ ​ problem. It crashes with segmentation fault while selection/deselection occurs... Test sample and the case: https://github.com/milabs/QtSampleModel/tree/treemodel Also, looks like that model doesn't operate with QTableView ​ ​ correctly. The patch shows

Re: set passwords only if changed

2015-09-04 Thread Jan Grulich
Hi, you can add me to CC or send the mail directly to me next time, otherwise it's possible I won't notice it. On Friday 04 of September 2015 07:45:52 Boettger, Heiko wrote: > Hi Jan > > when I don't read the secrets via NetworkManager::Connection::secrets and > store the changes applied on a s

set passwords only if changed

2015-09-04 Thread Boettger, Heiko
Hi Jan when I don't read the secrets via NetworkManager::Connection::secrets and store the changes applied on a setting the passwords are always cleared. I assume the passwords are replaced by the empty string because I never set them. I tried to filter the secrets out by removing the password