Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/ --- (Updated Aug. 20, 2015, 3:17 a.m.) Review request for KDE Frameworks. C

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote: > > I meant all the explicit, not only this one, by declaring it explicit we > > are changing the source compatibility, personally i'd reduce the patch to > > just the foreach const & Ah, I see. So these warnings about explicit ctors are

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/#review84068 --- I meant all the explicit, not only this one, by declaring it e

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

> On Aug. 19, 2015, 5:52 p.m., Volker Krause wrote: > > Sorry, this does not change the KMail case, it's still hitting the disk for > > the first icon of each type requested via QIcon::fromTheme, after that the > > in-memory cache kicks in. > > > > IIUC the problem is that on the pure QIcon::f

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

> On Aug. 19, 2015, 5:52 p.m., Volker Krause wrote: > > Sorry, this does not change the KMail case, it's still hitting the disk for > > the first icon of each type requested via QIcon::fromTheme, after that the > > in-memory cache kicks in. > > > > IIUC the problem is that on the pure QIcon::f

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/#review84060 --- Sorry, this does not change the KMail case, it's still hitting

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/ --- (Updated Aug. 19, 2015, 3:51 p.m.) Review request for KDE Frameworks. C

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/#review84048 --- src/kfilterdev.h (line 47)

Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Private Qml pugin for Baloo

I am planning to add a baloo-monitor model to baloo's Qml plugin. The problem is that we cannot guarantee API stability right now. Is exporting a new plugin under the namespace org.kde.baloo.experimental acceptable or is there some other way to go about it? -- Pinak Ahuja __

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

> On Aug. 19, 2015, 8:02 a.m., Mark Gaiser wrote: > > Hi David, > > > > This probably makes it faster (i have no doubt there), but i don't really > > follow how this works. > > Could you perhaps explain what you're doing exactly here? > > > > For instance, how can you determine if something is

Re: Review Request 124746: [KDesktopFile] add readMimeType

> On Aug. 18, 2015, 9:47 nachm., David Faure wrote: > > I'm still very surprised by the use case. How are you getting the full path > > to an application .desktop file without using the KService framework? It > > sounds like parsing all application desktop files by hand, which sounds > > horri

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/#review84027 --- Hi David, This probably makes it faster (i have no doubt ther

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/#review84026 --- Awesome, thanks! I'll test it on KMail tonight. - Volker Krau

Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/ --- Review request for KDE Frameworks, Christoph Feck and Volker Krause. Repo

Re: assert in kservicetypefactory.cpp

On Tue, 18 Aug 2015, David Faure wrote: On Tuesday 18 August 2015 10:45:00 Boudewijn Rempt wrote: if (!bus->isServiceRegistered(KDED_SERVICE_NAME)) { evaluates to false I'm confused by the possible double negation. Do you mean isServiceRegistered returns true? Er, I mean that the execution