Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

2015-08-10 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83685 --- Ship it! I'm not the reviewer for kdelibs4support but I have

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

2015-08-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 21:51:21 + Build duration: 13 min CHANGE SET Revision e54d817142cb02a63588004e67603171a7e4e2b2 by David

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

2015-08-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 21:51:21 + Build duration: 13 min CHANGE SET Revision e54d817142cb02a63588004e67603171a7e4e2b2 by David

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux, gcc - Build # 56 - Unstable!

2015-08-10 Thread David Faure
On Monday 10 August 2015 08:08:57 no-re...@kde.org wrote: > Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), > Total: 46 test(s)Failed: TestSuite.kpasswdservertest My bad. Fixed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

2015-08-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 21:51:21 + Build duration: 12 min CHANGE SET Revision e54d817142cb02a63588004e67603171a7e4e2b2 b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

2015-08-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 21:51:21 + Build duration: 12 min CHANGE SET Revision e54d817142cb02a63588004e67603171a7e4e2b2 b

Re: Review Request 124690: Show custom folder icons again

2015-08-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124690/#review83673 --- Ship it! Good catch. Just two small issues with the unittest.

Review Request 124690: Show custom folder icons again

2015-08-10 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124690/ --- Review request for KDE Frameworks, Àlex Fiestas and David Faure. Bugs: 35

Re: Accidentally exported private classes

2015-08-10 Thread Volker Krause
On Monday 10 August 2015 14:38:34 David Faure wrote: > On Monday 10 August 2015 13:23:05 Volker Krause wrote: > > Yep, and there are more reasons for not using nested classes for this and > > following the Qt scheme instead, such as the Q_D/Q_Q macros for example. > > Right. > > > For existing co

Re: Accidentally exported private classes

2015-08-10 Thread David Faure
On Monday 10 August 2015 13:23:05 Volker Krause wrote: > Yep, and there are more reasons for not using nested classes for this and > following the Qt scheme instead, such as the Q_D/Q_Q macros for example. Right. > For existing code it is however a quite substantial (although not > particularl

Re: Accidentally exported private classes

2015-08-10 Thread Volker Krause
On Monday 10 August 2015 13:06:29 David Faure wrote: > On Monday 10 August 2015 11:47:43 Volker Krause wrote: > > Hi, > > > > it turns out KF5 (and PIM, which is where I started looking into this) > > have > > quite some unintentionally exported private symbols (2000+ for PIM and the > > KF5 subse

Re: Accidentally exported private classes

2015-08-10 Thread David Faure
On Monday 10 August 2015 11:47:43 Volker Krause wrote: > Hi, > > it turns out KF5 (and PIM, which is where I started looking into this) have > quite some unintentionally exported private symbols (2000+ for PIM and the > KF5 > subset used by it, I'd not entirely trust the tool yet though ;) ). >

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

2015-08-10 Thread Luca Sartorelli
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- (Updated Aug. 10, 2015, 9:56 a.m.) Review request for KDE Frameworks. R

Accidentally exported private classes

2015-08-10 Thread Volker Krause
Hi, it turns out KF5 (and PIM, which is where I started looking into this) have quite some unintentionally exported private symbols (2000+ for PIM and the KF5 subset used by it, I'd not entirely trust the tool yet though ;) ). This is mainly caused by using nested private classes, those inherit

Re: Review Request 124208: Fallback for componentFriendlyForAction name resolving

2015-08-10 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124208/#review83642 --- It looks that this patch doesn't work as it should. For me ac

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 51 - Still Unstable!

2015-08-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 07:39:17 + Build duration: 12 min CHANGE SET Revision 231bd26df121552f17e0069dc03cdb3345f59516

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 56 - Unstable!

2015-08-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 07:39:17 + Build duration: 13 min CHANGE SET Revision 231bd26df121552f17e0069dc03cdb3345f59516 by Davi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 56 - Unstable!

2015-08-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Aug 2015 07:39:17 + Build duration: 13 min CHANGE SET Revision 231bd26df121552f17e0069dc03cdb3345f59516 by Davi

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

2015-08-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/ --- (Updated Aug. 10, 2015, 7:48 a.m.) Status -- This change has been ma