Re: Review Request 124646: Let the RowLayout figure out the size of the label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124646/#review83526 --- Ship it! Ran the buttons.qml test file, all seems fine. - Da

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

> On aug 6, 2015, 3:10 p.m., Mark Gaiser wrote: > > src/kconcatenaterowsproxymodel.h, line 58 > > > > > > Why do you inherit from QAbstractItemModel? You seem to be making a > > quite fancy proxy model where mult

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

> On Aug. 6, 2015, 3:10 p.m., Mark Gaiser wrote: > > src/kconcatenaterowsproxymodel.h, line 58 > > > > > > Why do you inherit from QAbstractItemModel? You seem to be making a > > quite fancy proxy model where mul

Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83501 --- Ship it! This is really cool, I even thought of coming up wit

Re: Review Request 124646: Let the RowLayout figure out the size of the label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124646/#review83500 --- Ship it! src/declarativeimports/plasmastyle/ButtonStyle.qml

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83499 --- src/kconcatenaterowsproxymodel.h (line 58)

Review Request 124646: Let the RowLayout figure out the size of the label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124646/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83495 --- Ship it! Ship It! - David Edmundson On Aug. 6, 2015, 12:41

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/ --- (Updated Aug. 6, 2015, 12:41 p.m.) Review request for KDE Frameworks. C

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

> On Aug. 6, 2015, 12:33 p.m., David Edmundson wrote: > > src/kconcatenaterowsproxymodel.cpp, line 198 > > > > > > potentially if you remove the first sourceModel, the column count has > > changed too Well, I h

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83491 --- src/kconcatenaterowsproxymodel.cpp (lines 172 - 175)

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83487 --- can/should we proxy the roleNames from the first model as well

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/ --- (Updated Aug. 6, 2015, 12:15 p.m.) Review request for KDE Frameworks. C

Re: Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux, gcc - Build # 11 - Fixed!

On Thursday 06 August 2015 11:54:40 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD SUCCESS > Build URL: > https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Hi Scarlett, This code is not part of KDE Frameworks, can you remove kde-frameworks-devel from

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 06 Aug 2015 11:17:50 + Build duration: 4 min 10 sec CHANGE SET Revision 26ffad78dd7d10f0ff070adb136e9376c7f

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 06 Aug 2015 11:17:50 + Build duration: 4 min 10 sec CHANGE SET Revision 26ffad78dd7d10f0ff070adb136e9376c7f

Re: Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/#review83485 --- Ship it! Ship It! - Olivier Jean de Gaalon On Aug. 6, 2015

Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124644/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

> On Aug. 6, 2015, 7:13 a.m., David Faure wrote: > > If the goal is to query this property for the K menu for instance, aren't > > you missing an accessor in KService? OK, on the other hand, if this is the > > only user, then property("...") would do too, but still, compile-time > > checking i

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83476 --- If the goal is to query this property for the K menu for insta