Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-13 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82472 --- I like the concept, and have a whole bunch of nitpickery and a

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-07-13 Thread Hrvoje Senjan
> On June 15, 2015, 12:36 a.m., Alexander Potashev wrote: > > Please add "find_dependency(Qt5Core @REQUIRED_QT_VERSION@)" for > > completeness. > > > > Build of KrossUi currently cannot be disabled. If we wanted to aim server > > environments without QtWidgets, then we first need to make Kross

Re: Review Request 124328: Man pages for kapidox

2015-07-13 Thread Allen Winter
> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote: > > I thought our man pages are written in docbook and then translated by the > > usual docbook workflow? > > Albert Astals Cid wrote: > Correct. > > Luigi Toscano wrote: > Yes, because they can be translated. But that means a depende

Re: Review Request 123030: Let KHtml be useable w/o searching for private deps

2015-07-13 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- (Updated July 13, 2015, 6:54 p.m.) Status -- This change has been ma

Re: Review Request 124105: Adhere a bit better to the spec

2015-07-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review82468 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 4, 2015, 9:

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

2015-07-13 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82467 --- In general looks good. src/knotificationmanager.cpp (line 29

Jenkins-kde-ci: plasma-framework master kf5-qt5 ยป Linux,All,gcc - Build # 43 - Fixed!

2015-07-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/43/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 13 Jul 2015 18:13:44 + Build duration: 6 min 57 sec CHANGE SET Revision 81

Re: Review Request 124306: Don't choke on empty QIconItem

2015-07-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82278 --- Ship it! it would be more performant to delete the node if it

Re: Review Request 124328: Man pages for kapidox

2015-07-13 Thread David Faure
> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote: > > I thought our man pages are written in docbook and then translated by the > > usual docbook workflow? > > Albert Astals Cid wrote: > Correct. > > Luigi Toscano wrote: > Yes, because they can be translated. But that means a depende

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 13, 2015, 8:31 a.m.) Review request for KDE Frameworks, Jes