Re: Review Request 124266: Introduce an env variable to overwrite the platform name

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124266/#review82116 --- +1, not that I fully understand why this is needed... - Aleix

Re: Review Request 124105: Adhere a bit better to the spec

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review82115 --- +1 LGTM. - Aleix Pol Gonzalez On July 4, 2015, 9:18 p.m., S

Re: Review Request 124266: Introduce an env variable to overwrite the platform name

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124266/ --- (Updated July 6, 2015, 1:52 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-07-06 Thread Sebastian Kügler
> On July 3, 2015, 9:15 p.m., Alexander Potashev wrote: > > Why don't we store plugin metadata in JSON files? Look how they're used for > > KDevelop: https://svn.reviewboard.kde.org/r/7126/ > > > > I'm afraid that if we keep this patch and it gets released, but then we > > realize that X-KDE-F