Review Request 124212: kwindowsystem: Change source file layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/ --- (Updated June 29, 2015, 10:44 p.m.) Status -- This change has been m

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/ --- (Updated June 29, 2015, 4:40 p.m.) Review request for KDE Frameworks and

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81869 --- Ship it! Ship It! - David Faure On June 17, 2015, 11 p.m.,

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

> On June 22, 2015, 5:01 p.m., Sebastian Kügler wrote: > > ping. ping.. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81661 --

Re: Review Request 124208: Fallback for componentFriendlyForAction name resolving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124208/#review81855 --- Ship it! Ship It! - Harald Sitter On June 29, 2015, 9:18 a

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- (Updated June 29, 2015, 9:54 a.m.) Status -- This change has been ma

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81852 --- Ship it! Ship It! - David Faure On June 29, 2015, 9:39 a.m

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- (Updated June 29, 2015, 9:39 a.m.) Review request for KDE Frameworks. C

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

> On June 29, 2015, 8:40 a.m., David Faure wrote: > > src/karchive.cpp, line 684 > > > > > > The "/8 /8 %2" bit looks too arithmetic to me, this should be 'bitwise > > and' instead (faster, more approriate here,

Review Request 124208: Fallback for componentFriendlyForAction name resolving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124208/ --- Review request for KDE Frameworks and Harald Sitter. Repository: kglobala

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

> On June 29, 2015, 8:40 a.m., David Faure wrote: > > src/karchive.cpp, line 684 > > > > > > The "/8 /8 %2" bit looks too arithmetic to me, this should be 'bitwise > > and' instead (faster, more approriate here,

Re: Review Request 123831: Coding Style for main.cpp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/#review81849 --- Ship it! Ship It! - Mario Bensi On May 17, 2015, 4:10 p.m.

Re: Review Request 123830: Coding Style for main.cpp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/#review81848 --- Ship it! Ship It! - Mario Bensi On May 17, 2015, 4:10 p.m.

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81846 --- (Hehe, that unittest should clearly use some ++int rather than