Re: Review Request 124186: [runtime] Install headers and library for the private part

2015-06-26 Thread Martin Gräßlin
> On June 26, 2015, 7:05 p.m., Hrvoje Senjan wrote: > > src/runtime/CMakeLists.txt, line 26 > > > > > > I can't say what's more correct, as this would be a precedent for > > installing private headers, maybe may

Re: Review Request 124186: [runtime] Install headers and library for the private part

2015-06-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/#review81783 --- src/runtime/CMakeLists.txt (line 26)

Re: Review Request 124186: [runtime] Install headers and library for the private part

2015-06-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/#review81779 --- And the relevant KWin patch: https://git.reviewboard.kde.org/r

Review Request 124186: [runtime] Install headers and library for the private part

2015-06-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: kgloba

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

2015-06-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/#review81768 --- The logic "if inotify is available then we don't need FAM" is