Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 9 - Fixed!

2015-06-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/9/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 26 Jun 2015 06:46:56 + Build duration: 1 min 21 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 8 - Fixed!

2015-06-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/8/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 26 Jun 2015 06:38:56 + Build duration: 2 min 50 sec CHANGE SET Revision ecad40

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

2015-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81749 --- At this point I wonder if three if()s wouldn't be a lot less c

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

2015-06-25 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- (Updated June 25, 2015, 12:44 p.m.) Review request for KDE Frameworks.

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-25 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81741 --- Nothing "criminal" I could see here. Side note: I guess action

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81740 --- Any comments? - Martin Klapetek On June 23, 2015, 2:04 p.m.

Re: Review Request 124165: Make KArchive preserve permissions from the files inside the archive

2015-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81738 --- Preserving the executable flag sounds like a good idea indeed,