Re: Re: Re: QPA plugin like functionality in frameworks?

On Wednesday 24 June 2015 23:20:21 Aleix Pol wrote: > On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin wrote: > > On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote: > >> On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin wrote: > >> > Hi framework-developers and packagers, > >> > > >> > with two fra

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

> On June 24, 2015, 9:17 p.m., Alex Merry wrote: > > src/kconfig_compiler/CMakeLists.txt, line 13 > > > > > > A bit late to the party, sorry, but this would be better as > > message(WARNING "..."). You're right.

Re: Re: QPA plugin like functionality in frameworks?

On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin wrote: > On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote: >> On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin wrote: >> > Hi framework-developers and packagers, >> > >> > with two frameworks I'm currently in the need to have something like QPA. >> >

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- (Updated June 24, 2015, 8:13 p.m.) Status -- This change has been ma

Re: This list needs more moderators

On Thursday 18 June 2015 21:44:29 Albert Astals Cid wrote: > I just came back from a 3 week holiday and there's emails (with one dating > back from June 1) that have not been moderated. > > So i guess we need more hands for the next time i decide to go on holiday :D I'm happy to volunteer. Alex

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81729 --- src/kconfig_compiler/CMakeLists.txt (line 13)

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/#review81726 --- src/lib/io/kdirwatch.cpp (lines 197 - 198)

Re: Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/ --- (Updated June 24, 2015, 6:05 p.m.) Status -- This change has been ma

Re: Review Request 124165: Make KArchive preserve permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- (Updated June 24, 2015, 5 p.m.) Review request for KDE Frameworks. Repo

Review Request 124165: Make KArchive preserve permissions from the files inside the archive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Re: Review Request 124143: Implement PersonsModel filtering facilities

> On June 21, 2015, 8:50 p.m., Aleix Pol Gonzalez wrote: > > I'm not very fond of the customProperty().isNull method, maybe it would > > make sense to add a ::ProvidedKeys field we can use. Any thoughts? Yeah, seems that would be better (::ProvidedProperties). - Martin -

Re: Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/#review81720 --- Ship it! src/personssortfilterproxymodel.h (line 42)

Re: Re: QPA plugin like functionality in frameworks?

On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote: > On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin wrote: > > Hi framework-developers and packagers, > > > > with two frameworks I'm currently in the need to have something like QPA. > > I > > want to make it possible to provide windowing-system sp

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81718 --- Ship it! Ok, looks good to me. Minor nitpick below :) autot

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

On jun 23, 2015, 12:26 p.m., David Faure wrote: > > Regarding the style. AStyle time i think ;) > > There is lots of function( arg ) instead of function(arg). ?besides that, > > some places could use more line breaks for readability (marked above). > > > > Some API questions. > > setSourceColum