Re: [kio] autotests: Add unit test for KIO::AccessManager

2015-05-31 Thread David Faure
On Monday 20 April 2015 15:23:26 Aleix Pol wrote: > Git commit 1c1501b5d98e30a42b4052d011dbce5a645b7545 by Aleix Pol. > Committed on 20/04/2015 at 15:22. > Pushed by apol into branch 'master'. > > Add unit test for KIO::AccessManager > > I was having some weird behavior I wanted to test, having a

Re: Review Request 123951: Change from GPL with KDE exception to LGPL to match the rest of the library

2015-05-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123951/#review81025 --- Ship it! Ship It! - David Edmundson On May 30, 2015, 9:26

Review Request 123972: Clarify exit value for Unique instances

2015-05-31 Thread Stefan BrĂ¼ns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123972/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Re: Review Request 123939: KAssistantDialog: Re-add the Help button that was present in KDELibs4 version

2015-05-31 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123939/#review81004 --- Ship it! Ship It! - Christoph Feck On May 29, 2015, 7:58 p

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

2015-05-31 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ --- (Updated May 31, 2015, 12:49 p.m.) Status -- This change has been ma

Re: Review Request 123946: Add api to disable plot grid lines

2015-05-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123946/ --- (Updated May 31, 2015, 12:39 p.m.) Status -- This change has been di

Re: Review Request 123946: Add api to disable plot grid lines

2015-05-31 Thread Marco Martin
> On May 31, 2015, 7:20 a.m., David Edmundson wrote: > > what doesn't work about > > > > setHorizontalGridLineCount: 0 ? because, didn't tought about it :p yup, horizontalGridLineCount: 0 is just fine ;) - Marco --- This is an auto

Re: Review Request 123930: Reduce temporary allocations.

2015-05-31 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123930/#review80991 --- Ship it! Seems good. Ship it - Laurent Montel On mai 30, 2

Re: Review Request 123946: Add api to disable plot grid lines

2015-05-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123946/#review80990 --- what doesn't work about setHorizontalGridLineCount: 0 ? - Da