Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread David Rosca
> On May 27, 2015, 2:55 p.m., Ivan Čukić wrote: > > Sorry for missing this one. You should ping me on IRC when you submit a > > patch and I miss it. > > > > Thanks for the patch, though, kactivities now include code similar to this. Ok, will do next time. Yep, you already fixed this crash, so

Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123778/#review80899 --- Sorry for missing this one. You should ping me on IRC when you

Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123778/ --- (Updated May 27, 2015, 2:43 p.m.) Status -- This change has been dis

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 27, 2015, 10:40 a.m.) Review request for KDE Frameworks. R

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-27 Thread Boudewijn Rempt
On Wed, 27 May 2015, Matthias Kretz wrote: Hi, On Monday 25 May 2015 11:50:35 Alex Merry wrote: The issue here is that Vc's macros implicitly assume that all compilation flags (including include paths) are done at the directory level (with include_directories() and setting CMAKE_CXX_FLAGS etc