Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 21, 2015, 4:02 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/#review80698 --- LGTM in general, but could you please add/update a unit test t

Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/ --- Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80695 --- Ship it! Awesome. I love the test! autotests/quickviewshare

KI18n programmer's guide mentions non-existent kcfgc parameter TranslationDomain

Hi, The current ki18n/docs/programmers-guide.md says that a TranslationDomain field in .kcfgc file can be used to set the translation domain. But in fact, KConfig's kconfig_compiler_kf5 does not read that field. Is there a plan to revive support for TranslationDomain in kconfig_compiler_kf5, or w

Re: Review Request 123850: Fix entities with wrong links

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123850/ --- (Updated May 21, 2015, 11:54 a.m.) Status -- This change has been ma

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 21, 2015, 11:36 a.m.) Review request for KDE Frameworks. R

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 21, 2015, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

> On May 21, 2015, 1:31 p.m., Milian Wolff wrote: > > src/klocalizedstring.cpp, line 23 > > > > > > shouldn't this be > > > > #include > > Bhushan Shah wrote: > ah yeah. meh; didn't fix it..

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/ --- (Updated May 21, 2015, 8:19 a.m.) Status -- This change has been mar

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

> On May 21, 2015, 1:31 p.m., Milian Wolff wrote: > > src/klocalizedstring.cpp, line 23 > > > > > > shouldn't this be > > > > #include ah yeah. - Bhushan

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80680 --- Ship it! Ship It! src/klocalizedstring.cpp (line 23)