Re: Review Request 123858: Fix memory leak in drags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858/#review80652 --- I really wonder why this is necessary. I just checked QtBase/

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80650 --- src/services/kservicegroupfactory.cpp (line 37)

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80649 --- src/kbuildsycoca/kbuildsycoca.cpp (lines 392 - 395)

Re: Review Request 123858: Fix memory leak in drags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858/#review80646 --- src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 312

Review Request 123858: Fix memory leak in drags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 123850: Fix entities with wrong links

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123850/#review80645 --- Ship it! Thanks; we should try to update the localized versio

Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

> On May 19, 2015, 3:12 p.m., Vishesh Handa wrote: > > autotests/test_settings.cpp, line 43 > > > > > > Minor thing, which is up to you. > > > > In this test you're allocating the `Speller` off the heap a

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

> On maj 19, 2015, 3:12 e.m., Vishesh Handa wrote: > > autotests/test_settings.cpp, line 43 > > > > > > Minor thing, which is up to you. > > > > In this test you're allocating the `Speller` off the heap a

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review80631 --- autotests/test_settings.cpp (line 43)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80630 --- src/kdeclarative/qmlobjectsharedengine.cpp (line 41)

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/ --- (Updated May 19, 2015, 2:32 p.m.) Status -- This change has been mar

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

> On May 5, 2015, 2:08 p.m., Marko Käning wrote: > > Looks like the test is still failing: > > > > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/ > > > > Anything I could do? > > David Faure wrote: > Yes, you

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

> On May 5, 2015, 2:08 p.m., Marko Käning wrote: > > Looks like the test is still failing: > > > > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/ > > > > Anything I could do? > > David Faure wrote: > Yes, you

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

> On mai. 5, 2015, 9:08 p.m., Marko Käning wrote: > > Looks like the test is still failing: > > > > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/ > > > > Anything I could do? > > David Faure wrote: > Yes, you

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review80625 --- Ship it! this looks good to me, esp. considering there is a u

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

> On May 5, 2015, 2:08 p.m., Marko Käning wrote: > > Looks like the test is still failing: > > > > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/ > > > > Anything I could do? > > David Faure wrote: > Yes, you

Re: Review Request 123838: Move from QDesktopWidget to QScreen

> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: > > src/notifybypopup.cpp, line 298 > > > > > > I fear that's now most likely no longer the same. I assume that > > QDesktopWidget::availableGeometry() is the

Re: Review Request 123838: Move from QDesktopWidget to QScreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- (Updated May 19, 2015, 12:40 p.m.) Review request for KDE Frameworks. C

Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123852/ --- Review request for KDE Frameworks, Laurent Montel, Martin Tobias Holmedahl

Review Request 123850: Fix entities with wrong links

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123850/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/ --- (Updated May 19, 2015, 8:01 a.m.) Review request for KDE Frameworks, Mark