Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123794: Implement "find previous" in KTextEdit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/ --- (Updated May 14, 2015, 11 p.m.) Status -- This change has been marke

Re: Review Request 123794: Implement "find previous" in KTextEdit.

> On May 14, 2015, 10:08 p.m., Jeremy Whiting wrote: > > Nice! cache the options, switch direction, findNext, then unswitch > > directions. Looks good. Yup, no trick - it's the way KFind's docu recommends doing it. [ok I did write that docu, ages ago...] - David ---

Re: Review Request 123794: Implement "find previous" in KTextEdit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/#review80365 --- Ship it! Nice! cache the options, switch direction, findNext,

Review Request 123794: Implement "find previous" in KTextEdit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwi

Re: Install location of myframework_version.h headers

On Wednesday 13 May 2015 19:25:36 Alex Merry wrote: > On Wednesday 13 May 2015 08:37:19 Kevin Funk wrote: > > Right, and I just noticed a problem I didn't think of before: There's no > > $PREFIX/include/KF5/$myframework/ where I could install > > ${myframework}_version.h into for some of the framew

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80362 --- Right, this code should have been ported to entry.insert(KIO:

Re: Install location of myframework_version.h headers

On Wednesday 13 May 2015 08:37:19 Kevin Funk wrote: > On Monday 04 May 2015 14:11:14 Kevin Funk wrote: > > On Monday 04 May 2015 13:11:05 David Faure wrote: > > > On Monday 04 May 2015 12:29:39 David Faure wrote: > > > You are right, all the version headers are in include/KF5 directly. > > > > > >

Re: Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- (Updated May 14, 2015, 3:34 p.m.) Status -- This change has been mar

Re: Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80356 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 14, 2015, 5:

Re: Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- (Updated May 14, 2015, 5:03 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 123791: Cache the theme in the integration plugin

> On May 14, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/integrationplugin/ktexttohtml.cpp, line 35 > > > > > > Shouldn't this be a Q_GLOBAL_STATIC? > > Daniel Vrátil wrote: > I thought that Q_GLOBAL_S

Re: Review Request 123791: Cache the theme in the integration plugin

> On May 14, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/integrationplugin/ktexttohtml.cpp, line 35 > > > > > > Shouldn't this be a Q_GLOBAL_STATIC? I thought that Q_GLOBAL_STATIC holds a pointer to the ob

Re: Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80345 --- src/integrationplugin/ktexttohtml.cpp (line 35)

Re: Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80341 --- +1 - Martin Klapetek On May 14, 2015, 1:48 p.m., Daniel Vrá

Review Request 123791: Cache the theme in the integration plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- Review request for KDE Frameworks. Repository: kemoticons Description -

Re: Versioning of Frameworks

Hello, On Tuesday 12 May 2015 09:22:12 David Faure wrote: > On Monday 11 May 2015 15:51:20 Christian Mollekopf wrote: > > I think there are two possibilities: > > * "master" is the development branch and we have a separate "release" > > branch > > => contributors have it easier because that is per