Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 13, 2015, 6:45 a.m., Kevin Funk wrote: > > I'd reorder the code: > > > > ``` > > ... > > > > include(FeatureSummary) > > > > find_package(ECM ...) > > set_target_properties(ECM ...) > > feature_summary(...) > > > > ... > > ``` > > > > I know that it is a bit harder to script this wa

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80275 --- I'd reorder the code: ``` ... include(FeatureSummary) find_

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 14:11:14 Kevin Funk wrote: > On Monday 04 May 2015 13:11:05 David Faure wrote: > > On Monday 04 May 2015 12:29:39 David Faure wrote: > > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > > The issue could be easily fixed by moving the myframework_version.h > > > > into

Re: Circular dependency in kde-build-metadata

On Tue, May 12, 2015 22:10:22 Michael Pyne wrote: > In fact the one that's *probably* tripping is that all kde/* modules depend > on kf5umbrella, which is a virtual dependency on all frameworks/* modules, > including frameworks/frameworkintegration. This would cause > kde/workspace/oxygen-fonts to

Re: Circular dependency in kde-build-metadata

On Mon, May 4, 2015 13:51:52 Daniel Vrátil wrote: > Hi, > > commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c ("frameworksintegration > tests want oxygen-fonts") in kde-build-metadata has introduced a circular > dependency between frameworkintegration and oxygen, leading to > > $ kdesrc-build --ref

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 12, 2015, 7:41 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > I'd like to know other people's opinion on this, as this should end up on > > most frameworks. > > Personally I'm unsure that showing the url will enlighten people, but it's > > better that than the terribly verbose and use

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80270 --- +1 I'd like to know other people's opinion on this, as this s

Re: Review Request 123745: Stop producing warnings about CMP0037 policy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123745/#review80269 --- Ship it! Good job! - Aleix Pol Gonzalez On May 13, 2015, 2

Re: Review Request 123743: Fix missing category to silence `desktop-file-validate`

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123743/#review80268 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 13, 2015, 1:

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- (Updated May 12, 2015, 6:28 p.m.) Review request for KDE Frameworks and J

Review Request 123745: Stop producing warnings about CMP0037 policy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123745/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kau

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 12, 2015, 4:49 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 32 > > > > > > Do you think this is needed? It's REQUIRED anyway. Oops, I did this wrong, I'll update the patch in a bit at home. t

Re: Review Request 123731: Cleanup handling of notifications closing

> On May 13, 2015, 12:54 a.m., Jan Kundrát wrote: > > Is it OK to have a non-null main object whose d-ptr is nullptr already? If > > not, can you fix the cause of that? It's not and I don't fully understand why that happens (and as mentioned I could never reproduce), but it's what those backtr

Review Request 123743: Fix missing category to silence `desktop-file-validate`

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123743/ --- Review request for KDE Frameworks. Repository: ksshaskpass Description

Re: Review Request 123731: Cleanup handling of notifications closing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123731/#review80265 --- Is it OK to have a non-null main object whose d-ptr is nullptr

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80264 --- CMakeLists.txt (line 32)

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/#review80263 --- tests/netaccesstest.cpp (line 39)

New framework: BluezQt

Hi all, I'd like to submit bluez-qt [1] for a review and then release it as part of frameworks 5.11. It is used in Bluedevil since the first release with Plasma 5.3. I have worked on API changes (it is source incompatible from the 5.3 version) and also added a new tests (including QML tests). I b

Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

> On May 12, 2015, 3:49 p.m., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. > > Michael Palimaka wrote: > It looks like

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80252 --- src/kdeclarative/qmlobjectsharedengine.h (line 57)

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

> On Mai 12, 2015, 3:49 nachm., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. > > Michael Palimaka wrote: > It looks li

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 12, 2015, 5:12 p.m.) Review request for KDE Frameworks. Su

Review Request 123737: Update URL to something that's fetchable.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:10 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

> On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 62 > > > > > > this needs to be initialised. line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine =

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:05 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

> On May 12, 2015, 3:49 p.m., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. It looks like it was introduced in 999e774b3ce1

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 --- src/kdeclarative/qmlobject.h (line 81)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 --- src/kdeclarative/qmlobject.cpp (line 176)

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80247 --- Was the old code a part of some release? If yes, this should g

Re: Review Request 123736: single QQmlEngine for all applets

> On May 12, 2015, 3:44 p.m., Kai Uwe Broulik wrote: > > > For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp > > > will still have own engine > > > > You mean SharedEngine? :) that :) - Marco --- This is an auto

Re: Review Request 123736: single QQmlEngine for all applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/#review80243 --- > For compatibility, applets without X-Plasma-RequiredExtensio

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 3:35 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 --- Can you make the diff against the branch root instead of origi

Review Request 123736: single QQmlEngine for all applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- (Updated May 12, 2015, 12:49 p.m.) Status -- This change has been ma

Review Request 123731: Cleanup handling of notifications closing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123731/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Kross module loading is broken since KF5.0.0

On Mon, May 11, 2015 at 6:37 PM, Alexander Potashev wrote: > 3. Make module names case insensitive. This can be implemented in > Kross framework by listing and filtering directory contents instead of > checking for a specific file. It will be slower and this looks like a > hack to me. > I would

Re: kconfiggui symbol retraction

On Tue, May 12, 2015 at 12:51 PM, David Faure wrote: > On Tuesday 12 May 2015 11:57:44 Harald Sitter wrote: >> not quite sure how it got lost >> >> - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 >> + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base >> 5.9.0+git20150512.0743+15.04-0 >> +#MI

Re: kconfiggui symbol retraction

On Tuesday 12 May 2015 11:57:44 Harald Sitter wrote: > not quite sure how it got lost > > - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 > + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base > 5.9.0+git20150512.0743+15.04-0 > +#MISSING: 5.9.0+git20150512.0743+15.04-0# > _ZN10KConfigGui17ses

Re: Review Request 123542: [runtime] Move platform specific code into plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- (Updated May 12, 2015, 10:50 a.m.) Status -- This change has been ma

kconfiggui symbol retraction

not quite sure how it got lost - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base 5.9.0+git20150512.0743+15.04-0 +#MISSING: 5.9.0+git20150512.0743+15.04-0# _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 __

Re: Versioning of Frameworks

On Tue, May 12, 2015, at 09:22 AM, David Faure wrote: > On Monday 11 May 2015 15:51:20 Christian Mollekopf wrote: > > I think there are two possibilities: > > * "master" is the development branch and we have a separate "release" > > branch > > => contributors have it easier because that is perhap

Re: Versioning of Frameworks

On Monday 11 May 2015 15:51:20 Christian Mollekopf wrote: > I think there are two possibilities: > * "master" is the development branch and we have a separate "release" > branch > => contributors have it easier because that is perhaps more common, > and the people releasing need to know that they s