Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-05-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ --- (Updated May 3, 2015, 11:24 p.m.) Status -- This change has been mar

Re: Review Request 123551: Introduce the deprecated plugin system for now

2015-05-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated May 3, 2015, 10:43 p.m.) Status -- This change has been mar

Re: Review Request 123551: Introduce the deprecated plugin system for now

2015-05-03 Thread Aleix Pol Gonzalez
> On May 3, 2015, 10:21 p.m., David Faure wrote: > > This sounds like something that should go into KF 5.10. > > > > If this is temporary code then doing it "only if new-style plugins haven't > > been found" doesn't really matter much IMHO. Yes, that's the idea. - Aleix ---

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Albert Astals Cid
> On mai. 3, 2015, 12:34 p.m., Albert Astals Cid wrote: > > I'm confused, the title say "Remove KAboutData" and then goes and changes > > i18n while breaking it? > > > > I mean i18n handling is relatively easy, and we have pretty good > > documentation at > > https://techbase.kde.org/Developm

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Martin Klapetek
> On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote: > > I'm confused, the title say "Remove KAboutData" and then goes and changes > > i18n while breaking it? > > > > I mean i18n handling is relatively easy, and we have pretty good > > documentation at > > https://techbase.kde.org/Developmen

Re: Review Request 123551: Introduce the deprecated plugin system for now

2015-05-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79808 --- Ship it! This sounds like something that should go into KF 5.

Re: Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QList

2015-05-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123601/#review79797 --- Why not at least allow people to write 3 shortcuts in a .rc fi

Re: Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QList

2015-05-03 Thread Mladen Milinkovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123601/ --- (Updated May 3, 2015, 2:46 p.m.) Review request for KDE Frameworks. Bug

Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QList

2015-05-03 Thread Mladen Milinkovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123601/ --- Review request for KDE Frameworks. Bugs: 343665 https://bugs.kde.org/

Re: Versioning of Frameworks

2015-05-03 Thread Sandro Knauß
Hey, > Or the other way around -- if it is at one point indeed working with these > versions, what will happen is that someone will use a new feature from an > underlying framework at some point, and forget to upgrade the required > version. This will happen many times per month, not just once a y

Re: [knewstuff] /: registerServicesByCategory: add "screenshot-take"

2015-05-03 Thread Gregor Mi
Hi David, I just commited a fix for the unit tests. > In fact, is tests/kmoretoolstest supposed to be a unittest ? It has both unittests and interactive dialogs in it. The interactive dialogs can be disabled via a flag but I guess I should separate this more cleanly. > but releasing something

Re: Versioning of Frameworks

2015-05-03 Thread Albert Astals Cid
El Dijous, 30 d'abril de 2015, a les 10:35:59, Kevin Funk va escriure: > On Wednesday, April 29, 2015 21:43:20 David Faure wrote: > > On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: > > > Use-case: Potential contributor working on KDevelop: > > > - Has KF5 installed from distro packages > > >

Re: Versioning of Frameworks

2015-05-03 Thread Gregor Mi
Hi, I would like to add that there are other much bigger frameworks which have a lot more resources at hand and also have one single version under which all of the many submodules are released: Java (Java 6, Java 7, Java 8, ...) https://en.wikipedia.org/wiki/Java_version_history .NET (3.0, 3.

Re: Review Request 123598: kio: Fix more issues with QFile::rename return value

2015-05-03 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123598/ --- (Updated May 3, 2015, 12:39 p.m.) Status -- This change has been mar

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review79794 --- I'm confused, the title say "Remove KAboutData" and then goes

Re: Review Request 123598: kio: Fix more issues with QFile::rename return value

2015-05-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123598/#review79793 --- Ship it! Thanks! - David Faure On May 3, 2015, 12:05 p.m.,

Review Request 123598: kio: Fix more issues with QFile::rename return value

2015-05-03 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123598/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 123567: Add an Arch Linux package search provider

2015-05-03 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567/ --- (Updated May 3, 2015, 9:30 a.m.) Status -- This change has been mark

Re: [knewstuff] /: registerServicesByCategory: add "screenshot-take"

2015-05-03 Thread David Faure
On Sunday 03 May 2015 09:11:53 Gregor Mi wrote: > Hi David, > > I just commited a fix for the unit tests. > > > In fact, is tests/kmoretoolstest supposed to be a unittest ? > > It has both unittests and interactive dialogs in it. The interactive dialogs > can be disabled via a flag but I guess I