Re: Opinions on KIO Slave side sorting? Possible GSoC project?

On Thursday 08 January 2015 10:45:13 Mark Gaiser wrote: (wow, time flies) > The issue i see here is different processes. KIO::listDir is a process, > KDirListerCache lives in the client process. I guess you didn't mean this litterally, because in that case it's wrong, both happen in the client

Re: [knewstuff] /: registerServicesByCategory: add "screenshot-take"

Hi Gregor, does the unittest pass for you? https://build.kde.org/view/Frameworks%20kf5-qt5/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/testReport/%28root%29/TestSuite/kmoretoolstest/ I get the same failures on my system. In fact, is tests/kmoretoolstest supposed to be

Re: CI for kf5-qt5 is not green anymore

On Saturday, May 02, 2015 08:36:02 PM David Faure wrote: > On Saturday 02 May 2015 06:56:06 Scarlett Clark wrote: > > This will be fixed when the builders free up so I can restart jenkins. > > XDG* > > is was not set. So things should improve after restart. > > Thanks. Did a restart happen by now

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 7:26 p.m.) Status -- This change has been mark

Review Request 123595: Fix KUser test for Mac.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/ --- Review request for KDE Frameworks and Marko Käning. Repository: kcoreaddo

Re: CI for kf5-qt5 is not green anymore

On Saturday 02 May 2015 06:56:06 Scarlett Clark wrote: > This will be fixed when the builders free up so I can restart jenkins. XDG* > is was not set. So things should improve after restart. Thanks. Did a restart happen by now? I tried to kick a new kparts build to see if it worked better, but .

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79787 --- Ship it! Ship It! - David Faure On May 2, 2015, 4:46 p.m.,

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 4:46 p.m.) Review request for KDE Frameworks, Plasm

Re: CI for kf5-qt5 is not green anymore

On Saturday, May 02, 2015 10:20:27 AM David Faure wrote: > KMainWindow_UnitTest::testDefaultName() Cannot create window: no screens > available Yes it is a CI issue. We connect to slaves via SSH and therefore GUI is not available. I am not a Mac person so this requires the assistance of Mac folks

Re: CI for kf5-qt5 is not green anymore

On Saturday, May 02, 2015 10:00:15 AM David Faure wrote: > On my checklist before making a KF5 release: > * Ensure that CI is green. > > What a surprise today CI is definitely not green! > https://build.kde.org/view/Frameworks%20kf5-qt5/ > > One thing is: Mac OSX was added, so many jobs are

Re: Review Request 123590: ftp slave: Fix conditions for QFile::rename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123590/ --- (Updated May 2, 2015, 11:03 a.m.) Status -- This change has been mar

Re: Review Request 123589: kioexec: Fix path for writable location for kurl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123589/ --- (Updated May 2, 2015, 11:03 a.m.) Status -- This change has been mar

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated May 2, 2015, 9:04 a.m.) Status -- This change has been mark

Re: CI for kf5-qt5 is not green anymore

On Saturday 02 May 2015 10:00:15 David Faure wrote: > Ben, Scarlett: did something change in the setup? Is XDG_DATA_DIRS not > pointing to the install dir of the framework anymore? Similarly, shared-mime-info (found via XDG_DATA_DIRS on Linux) isn't found anymore, breaking at least kparts and kic

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/ --- (Updated May 2, 2015, 8:58 a.m.) Status -- This change has been mark

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

> On mai 2, 2015, 8:50 matin, David Faure wrote: > > autotests/kdelibs4configmigratortest.cpp, line 85 > > > > > > The copy that happens above is for creating the KDE4 test files, right? > > > > My QCOMPA

Re: Review Request 123589: kioexec: Fix path for writable location for kurl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123589/#review79779 --- Ship it! Ooops! Good find, thanks. - David Faure On May 2,

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79780 --- Ship it! Ship it - Laurent Montel On mai 2, 2015, 8:17 mat

Re: Review Request 123590: ftp slave: Fix conditions for QFile::rename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123590/#review79777 --- Ship it! Indeed, bad porting from ::rename() in 4cf434b4e892.

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79776 --- autotests/kdelibs4configmigratortest.cpp (line 85)

Re: Review Request 123590: ftp slave: Fix conditions for QFile::rename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123590/ --- (Updated May 2, 2015, 8:38 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 123589: kioexec: Fix path for writable location for kurl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123589/ --- (Updated May 2, 2015, 8:38 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79775 --- autotests/kdelibs4configmigratortest.cpp (line 85)

Re: CI for kf5-qt5 is not green anymore

On Saturday 02 May 2015 10:00:15 David Faure wrote: > (*) On the Mac, many tests fail with "Cannot create window: no screens > available". I think this is because they need a bundle, which can be done > by adding GUI to the ecm_add_test call, see kxmlgui 9abace028 for an > example. Hmm, that's not

Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/ --- Review request for KDE Frameworks and Laurent Montel. Repository: kcoread

CI for kf5-qt5 is not green anymore

On my checklist before making a KF5 release: * Ensure that CI is green. What a surprise today CI is definitely not green! https://build.kde.org/view/Frameworks%20kf5-qt5/ One thing is: Mac OSX was added, so many jobs are "green on linux, failing tests on mac". That's OK for now, no regressio

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/#review79774 --- Ship it! Well, you could still set local variables in the lam

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79773 --- Ship it! Ship It! - David Faure On May 1, 2015, 9:55 p.m.,