Re: Review Request 123575: Improve debug information for some plasmoids

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/#review79740 --- Ship it! Ship It! - Marco Martin On April 30, 2015, 5:35 p

Review Request 123575: Improve debug information for some plasmoids

2015-04-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

Re: Versioning of Frameworks

2015-04-30 Thread David Faure
On Thursday 30 April 2015 10:35:59 Kevin Funk wrote: > However, I think it could be helpful to be able to build master branch of > $MODULE against a stable version of its dependencies for *development > purposes*, which currently isn't possible. OK, that is easily fixable. I can raise the versio

Re: Versioning of Frameworks

2015-04-30 Thread Sebastian Kügler
On Wednesday, April 29, 2015 21:45:14 David Faure wrote: > but they don't > realize when writing QSignalSpy(obj, &Class::member) that this syntax > wasn't available in Qt 5.2. I wasn't aware that this has been added, very useful. Thanks! :-) -- sebas http://www.kde.org | http://vizZzion.org |

Re: Review Request 123570: Add a method to insert new known structures

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- (Updated April 30, 2015, 9:31 a.m.) Review request for KDE Frameworks and

Review Request 123570: Add a method to insert new known structures

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
> On April 28, 2015, 2:35 p.m., David Faure wrote: > > src/core/global.cpp, line 407 > > > > > > startsWith('.') (using the QChar overload) > > > > Do we even need this special case, with the way the co

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
> On April 28, 2015, 2:35 p.m., David Faure wrote: > > src/core/global.cpp, line 407 > > > > > > startsWith('.') (using the QChar overload) > > > > Do we even need this special case, with the way the co

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 30, 2015, 9:05 a.m.) Review request for KDE Frameworks, Pl

Re: Versioning of Frameworks

2015-04-30 Thread Kevin Funk
On Wednesday, April 29, 2015 21:43:20 David Faure wrote: > On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: > > Use-case: Potential contributor working on KDevelop: > > - Has KF5 installed from distro packages > > - KDevelop/KDevPlatform compiled from Git > > - There's a bug in ktexteditor (ti

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-30 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/ --- (Updated Dub. 30, 2015, 8:33 dop.) Review request for KDE Frameworks and

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-04-30 Thread Martin Klapetek
> On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-30 Thread Marco Martin
> On April 29, 2015, 8:53 p.m., Alex Richardson wrote: > > src/kpackage/packageloader.cpp, line 273 > > > > > > This will crash if there is no filter. > > > > `if (!filter || filter(plugin))` should work