Re: Review Request 123542: [runtime] Move platform specific code into plugins

> On April 28, 2015, 7:31 p.m., Alex Richardson wrote: > > src/runtime/globalshortcutsregistry.cpp, line 40 > > > > > > You could use > > `KPluginLoader::forEachPlugin("org.kde.kglobalaccel5.platforms", [&](const

Re: Review Request 123551: Introduce the deprecated plugin system for now

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79650 --- Maybe you want to query kservice only in case plugins haven't

Review Request 123551: Introduce the deprecated plugin system for now

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Repository:

Re: Versioning of Frameworks

On Tue, Apr 28, 2015 at 12:17 PM, Christian Mollekopf wrote: > Hey, > > For the Kolab Groupware Server we use some KDE libraries on the server. > Servers being what they are, the libraries we require are often not > available by default because the systems are too old, and we end-up > backporting

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated April 28, 2015, 8:43 p.m.) Review request for KDE Frameworks.

Re: Review Request 123402: Moves away from KService

> On April 28, 2015, 8:26 p.m., Hrvoje Senjan wrote: > > As this breaks released KTp (15.04.x), IMHO best is either to revert this > > one, or still provide fallback for kservice plugins... > > I know KF5 guarantees binary and source compatibility, not explicitly > > runtime, but this will upse

Re: Review Request 123402: Moves away from KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/#review79641 --- As this breaks released KTp (15.04.x), IMHO best is either to

Review Request 123544: kioclient ls: properly construct QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: Review Request 123542: [runtime] Move platform specific code into plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/#review79637 --- src/runtime/globalshortcutsregistry.cpp (line 40)

Versioning of Frameworks

Hey, For the Kolab Groupware Server we use some KDE libraries on the server. Servers being what they are, the libraries we require are often not available by default because the systems are too old, and we end-up backporting what we need. To make this feasible in pre-framework times I had to creat

Re: Review Request 123534: Add public dependency on ModemManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/#review79635 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2:44

Re: Review Request 123533: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123533/#review79634 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2:42

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/#review79633 --- It worked here, so it's a +1 from me. I just would like the ex

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79631 --- src/core/global.cpp (line 396)

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 28, 2015, 2:38 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79629 --- src/core/global.cpp (line 396)

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123525/#review79627 --- Ship it! Nice and simple :-) - David Faure On April 27, 20

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

> On April 27, 2015, 3:10 p.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 279 > > > > > > Ouch! A nested event loop! Nasty. Opens the door to unexpected > > reentrancy > > > > N

Review Request 123542: [runtime] Move platform specific code into plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- Review request for KDE Frameworks, kdewin and Martin Klapetek. Repository

Re: Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/ --- (Updated April 28, 2015, 9:48 a.m.) Status -- This change has been m

Re: Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/#review79619 --- Ship it! Ship It! - David Edmundson On April 28, 2015, 8:3

Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/ --- Review request for KDE Frameworks and Plasma. Bugs: 345973 https://bu