Re: Review Request 123490: Fix crash when using x11 functionality on platform wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123490/ --- (Updated April 28, 2015, 6:24 a.m.) Status -- This change has been m

Re: Review Request 123464: Drop dead code path to get compositingActive without QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123464/ --- (Updated April 28, 2015, 6:24 a.m.) Status -- This change has been m

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79611 --- Could you make a testcase for this? - Mark Gaiser On apr 27

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated April 27, 2015, 6:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123525/#review79591 --- +1 - Marco Martin On April 27, 2015, 12:23 p.m., Emmanuel P

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

> On April 27, 2015, 5:10 p.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 279 > > > > > > Ouch! A nested event loop! Nasty. Opens the door to unexpected > > reentrancy > > > > N

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

> On April 27, 2015, 5:10 p.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 279 > > > > > > Ouch! A nested event loop! Nasty. Opens the door to unexpected > > reentrancy > > > > N

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123523/#review79577 --- src/widgets/kpropertiesdialog.cpp (line 279)

Review Request 123534: Add public dependency on ModemManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/ --- Review request for KDE Frameworks and Lamarque Souza. Repository: modemma

Review Request 123533: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123533/ --- Review request for KDE Frameworks and Lamarque Souza. Repository: network

Review Request 123532: Add find modules for ModemManager and NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/ --- Review request for KDE Frameworks and Lamarque Souza. Repository: extra-c

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated April 27, 2015, 3:30 p.m.) Review request for KDE Frameworks and

Review Request 123528: Add missing license file: COPYING.LGPL-2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123528/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwi

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123523/#review79569 --- Ship it! src/widgets/kpropertiesdialog.h (line 130)

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123525/ --- (Updated April 27, 2015, 2:23 p.m.) Review request for KDE Frameworks.

Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123525/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123523/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Places bookmark bug - Help needed

Thanks for all the feedback, I'll prepare the patches ASAP. * Remove bookmarks syncing code from KFilePlacesModel (KF5 and kdelibs4) * Use user-places.xbel instead of bookmarks.xml in KFilePlacesModel and Dolphin (KF5 and kdelibs4) Cheers, Emmanuel 2015-04-25 22:43 GMT+02:00 David Faure : > On

Re: Review Request 123477: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/ --- (Updated Dub. 27, 2015, 9:44 dop.) Status -- This change has been di

Re: Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123414/ --- (Updated April 27, 2015, 7:50 a.m.) Status -- This change has been m