Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79483 --- Ok, I think this should be last set of comments. One thing I

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 25, 2015, 3:39 a.m.) Review request for KDE Frameworks and

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

> On April 24, 2015, 2:47 p.m., Matthew Dawson wrote: > > autotests/kconfig_compiler/test13.cpp.ref, line 33 > > > > > > Is there a reason this got moved back? > > Aleix Pol Gonzalez wrote: > Well, Modified

Re: Review Request 123493: Fix leaky incubation controller

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/#review79481 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123492: Fix memory leak in AppletQuickItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79480 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

> On April 24, 2015, 8:47 p.m., Matthew Dawson wrote: > > autotests/kconfig_compiler/test13.cpp.ref, line 33 > > > > > > Is there a reason this got moved back? Well, Modified needs to be called together with Ch

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79473 --- Looks good, one last comment: autotests/kconfig_compiler/tes

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 24, 2015, 6:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > > > > > Just tested the patch myself on sonnet. > > > > The test indeed breaks if sonnet is not install

Review Request 123493: Fix leaky incubation controller

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 123492: Fix memory leak in AppletQuickItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79466 --- Ship it! Ship It! - Marco Martin On April 24, 2015, 4:33 p

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Review Request 123492: Fix memory leak in AppletQuickItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > > > > > Just tested the patch myself on sonnet. > > > > The test indeed breaks if sonnet is not instal

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79460 --- modules/ECMGeneratePriFile.cmake (line 179)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79458 --- modules/ECMGeneratePriFile.cmake (lines 177 - 179)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:21 p.m., Kevin Funk wrote: > > Hm, this could cause problems in the case where you generate multiple .pri > > files which depend on each other within one project. Problem .pri files are > > not yet installed, thus the QT modules are not yet available. > > > > I suggest tr

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- (Updated abr. 24, 2015, 3:26 p.m.) Review request for Extra Cmake Modules

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79454 --- Hm, this could cause problems in the case where you generate m

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79452 --- Ship it! modules/ECMGeneratePriFile.cmake (line 174)

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79450 --- autotests/kconfig_compiler/test13.cpp.ref (line 18)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79451 --- Cool stuff! :) Maybe you can add some documentation explainin

Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk. Re

Review Request 123490: Fix crash when using x11 functionality on platform wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123490/ --- Review request for KDE Frameworks. Bugs: 346496 https://bugs.kde.org/

kdepackages.h

kxmlgui has a file kdepackages.h which lists the products in bugzilla. This is used by the dialog in Help → Report Bug. It was horribly out of date so I've synced it with current bugzilla. David could you add to the release scripts to run make_kdepackages_updated.py in kxmlgui before release? S

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 24, 2015, 12:06 p.m.) Status -- This change has been

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 11:33 p.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > > > > > Why this manual loop instead of strlen()? Does that mean that null > > characters in the middle are vali