Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 6:06 p.m.) Status -- This change has been m

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review79143 --- src/kglobalaccel.cpp (line 653)

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

> On April 17, 2015, 6:16 p.m., Aleix Pol Gonzalez wrote: > > Wouldn't it have been easier to add the subdirectory in the interface? > > > > Or you want users of the library to specify the namespace? > > > > Also the former one would have been fine as long as the header and the > > export file

Re: Review Request 123402: Moves away from KService

> On April 17, 2015, 5:52 p.m., Vishesh Handa wrote: > > src/widgets/actions.cpp, line 34 > > > > > > If you want you can also change this to the new for syntax. But make sure that `personPluginList` is const, si

Re: Review Request 123402: Moves away from KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/#review79138 --- src/widgets/actions.cpp (line 34)

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/#review79137 --- Wouldn't it have been easier to add the subdirectory in the in

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/#review79136 --- Ship it! The patch looks good to me. Network firewall here bl

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 5:53 p.m.) Review request for KDE Frameworks, Da

Review Request 123402: Moves away from KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/ --- Review request for KDE Frameworks, KDEPIM and Martin Klapetek. Repository

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

> On April 17, 2015, 5:06 p.m., Alex Richardson wrote: > > KF5CoreAddonsMacros.cmake, line 108 > > > > > > I would also grep for Q_PLUGIN_METADATA(IID ... FILE foo.json). > > Also maybe make the macro name cu

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 5:34 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

> On April 17, 2015, 5:24 p.m., Hrvoje Senjan wrote: > > This breaks the build of plasma-workspace > > ``` > > [ 413s] In file included from > > /usr/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1:0, > > [ 413s] from > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5

Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- Review request for KDE Frameworks, David Faure and Jan Grulich. Repositor

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/#review79132 --- This breaks the build of plasma-workspace ``` [ 413s] In file

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79131 --- KF5CoreAddonsMacros.cmake (line 108)

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/ --- (Updated April 17, 2015, 4:53 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kinfocenter_stable_qt5 #13

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUIL

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79123 --- does this error out properly when the install namespace is emp

Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/ --- Review request for KDE Frameworks and Alex Richardson. Repository: kcorea

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/ --- (Updated April 17, 2015, 12:10 p.m.) Status -- This change has been

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/ --- (Updated April 17, 2015, 12:10 p.m.) Status -- This change has been

Re: Review Request 123390: Reorder member variables to reduce memory usage.

> On April 16, 2015, 8:43 p.m., Laurent Montel wrote: > > Hi volker > > What did you use as program to detect it ? > > Thanks for info. > > Volker Krause wrote: > The tool is called "elf-packcheck", part of > kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as > t

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- (Updated April 17, 2015, 8 a.m.) Status -- This change has been mark

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 17, 2015, 7:49 a.m.) Status -- This change has been m

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review79099 --- Ship it! Ship It! - Martin Gräßlin On April 17, 2015, 9:07

Re: Review Request 123390: Reorder member variables to reduce memory usage.

> On avr. 16, 2015, 8:43 après-midi, Laurent Montel wrote: > > Hi volker > > What did you use as program to detect it ? > > Thanks for info. > > Volker Krause wrote: > The tool is called "elf-packcheck", part of > kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

> On April 17, 2015, 7:18 a.m., Gregor Mi wrote: > > I did not receive an email on the final code changes. So this should > > trigger another one. > > Gregor Mi wrote: > . (still no email received. sorry for the potential noise) - Gregor

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

> On April 17, 2015, 7:18 a.m., Gregor Mi wrote: > > I did not receive an email on the final code changes. So this should > > trigger another one. . - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.r

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review79092 --- I did not receive an email on the final code changes. So this

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 17, 2015, 7:07 a.m.) Review request for KDE Frameworks, Ma

Re: Review Request 122981: add new method KGlobalAccel::shortcut(componentName, actionId)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 17, 2015, 7:07 a.m.) Review request for KDE Frameworks, Ma

Re: Review Request 123390: Reorder member variables to reduce memory usage.

> On April 16, 2015, 8:43 p.m., Laurent Montel wrote: > > Hi volker > > What did you use as program to detect it ? > > Thanks for info. The tool is called "elf-packcheck", part of kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as testing ground, the run on widgetadd