Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-04-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123376/#review79026 --- would you mind adding a testcase for it? - Martin Gräßlin O

Re: Review Request 123030: Let KHtml be useable w/o searching for private deps

2015-04-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/#review79013 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 18, 2015,

Re: Review Request 123030: Let KHtml be useable w/o searching for private deps

2015-04-15 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/#review79011 --- Ship it! not entirely sure what you mean with public dependen

Build failed in Jenkins: knewstuff_stable_qt5 #18

2015-04-15 Thread KDE CI System
See Changes: [codestruct] Introduce KMoreTools -- [...truncated 52 lines...] kcodecs - Branch master ki18n - Branch master kcoreaddons - Branch master kitemviews - Branch master

Build failed in Jenkins: knewstuff_master_qt5 #131

2015-04-15 Thread KDE CI System
See Changes: [codestruct] Introduce KMoreTools -- [...truncated 52 lines...] kguiaddons - Branch master kcodecs - Branch master ki18n - Branch master kcoreaddons - Branch maste

Re: [Kde-pim] KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Scarlett Clark
On Wednesday, April 15, 2015 09:17:22 PM Daniel Vrátil wrote: > On 15.04.2015 09:44, Scarlett Clark wrote: > > Here is a list of mostly compile failures and other tid bits that need > > to be > > resolved by the respective developers. If you know the developer of a > > project > > and they are not

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 9:21 p.m.) Status -- This change has been m

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 9:11 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Jeremy Whiting
> On April 15, 2015, 2:39 p.m., Jeremy Whiting wrote: > > Ship It! > > Gregor Mi wrote: > > As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. > > The install dir now looks like this: > http://wstaw.org/m/2015/04/15/plasma-des

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Gregor Mi
> On April 15, 2015, 8:39 p.m., Jeremy Whiting wrote: > > Ship It! > As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. The install dir now looks like this: http://wstaw.org/m/2015/04/15/plasma-desktopVd2099.png I wonder if this ok to ha

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78995 --- Ship it! Ship It! - Jeremy Whiting On April 15, 2015, 2:24

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 8:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2015-04-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121265/ --- (Updated April 15, 2015, 8:22 nachm.) Status -- This change has been

Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-04-15 Thread Yuxuan Shui
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123376/ --- Review request for KDE Frameworks. Bugs: 341959 https://bugs.kde.org/

Re: [Kde-pim] KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Daniel Vrátil
On 15.04.2015 09:44, Scarlett Clark wrote: Here is a list of mostly compile failures and other tid bits that need to be resolved by the respective developers. If you know the developer of a project and they are not on this list please forward this. All jobs can be viewed at : https://build-san

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread jbm
On Wednesday 15 April 2015 00.44:14 Scarlett Clark wrote: > Here is a list of mostly compile failures and other tid bits that need to be > resolved by the respective developers. If you know the developer of a > project and they are not on this list please forward this. All jobs can be > viewed at :

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Boudewijn Rempt
On Wed, 15 Apr 2015, Scarlett Clark wrote: calligra - All - compile fail. One way to make it build would be to remove the Vc dependency. We've still not figured out a way to make Vc's handling of INCLUDE_DIRECTORIES work with the new kf5 way of creating include directories -- see my mail to

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 15, 2015, 5:38 p.m.) Review request for KDE Frameworks and

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-15 Thread Aleix Pol Gonzalez
> On April 15, 2015, 5:20 p.m., Albert Astals Cid wrote: > > properties that are read only should have CONSTANT in the Q_PROPERTY, no? I wasn't sure. Checking the implementation I see that it's using a local variable rather than fetching the information from the configuration, so it's probably

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review78971 --- properties that are read only should have CONSTANT in the Q_PR

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 15, 2015, 5:11 p.m.) Review request for KDE Frameworks and

Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Scarlett Clark
On 04/15/2015 02:58 AM, Martin Klapetek wrote: On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark > wrote: Here is a list of mostly compile failures and other tid bits that need to be resolved by the respective developers. If you know the developer of a

Re: Review Request 123360: Introduce LoopSound flag

2015-04-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/ --- (Updated April 15, 2015, 11:21 a.m.) Status -- This change has been

Build failed in Jenkins: kinfocenter_stable_qt5 #12

2015-04-15 Thread KDE CI System
See Changes: [sitter] import [sitter] i18n++ [sitter] Rework layout [sitter] Avoid multiple spaces in processor name [sitter] List all processors [sitter] drop dead files [sitter] make copyright more windows-friendly [sitter] typ

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Aleix Pol
On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark wrote: > Here is a list of mostly compile failures and other tid bits that need to be > resolved by the respective developers. If you know the developer of a project > and they are not on this list please forward this. All jobs can be viewed at : > h

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Martin Klapetek
On Wed, Apr 15, 2015 at 12:02 PM, Ben Cooksley wrote: > On Wed, Apr 15, 2015 at 9:58 PM, Martin Klapetek > wrote: > > On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark > wrote: > >> > >> Here is a list of mostly compile failures and other tid bits that need > to > >> be > >> resolved by the respe

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Ben Cooksley
On Wed, Apr 15, 2015 at 9:58 PM, Martin Klapetek wrote: > On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark wrote: >> >> Here is a list of mostly compile failures and other tid bits that need to >> be >> resolved by the respective developers. If you know the developer of a >> project >> and they ar

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Martin Klapetek
On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark wrote: > Here is a list of mostly compile failures and other tid bits that need to > be > resolved by the respective developers. If you know the developer of a > project > and they are not on this list please forward this. All jobs can be viewed > a

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Sebastian Kügler
Hi Scarlett, On Wednesday, April 15, 2015 00:44:14 Scarlett Clark wrote: > Here is a list of mostly compile failures and other tid bits that need to be > resolved by the respective developers. If you know the developer of a > project and they are not on this list please forward this. All jobs can

KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Scarlett Clark
Here is a list of mostly compile failures and other tid bits that need to be resolved by the respective developers. If you know the developer of a project and they are not on this list please forward this. All jobs can be viewed at : https://build-sandbox.kde.org/ Most of these are osx failures.

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-04-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/ --- (Updated April 15, 2015, 7:37 a.m.) Status -- This change has been d