Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78950 --- Ship it! Ship It! - Lamarque Souza On April 14, 2015, 2:41

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Lamarque Souza
> On April 14, 2015, 3:50 p.m., Lamarque Souza wrote: > > src/notifybyaudio.cpp, line 89 > > > > > > Should not this patch be followed by another patch that set LoopSound > > flag for Persistant notifications tha

Re: Review Request 122910: Introduce KMoreTools

2015-04-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78941 --- As KMoreTools is going to be part of KNewStuff it should be us

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Martin Klapetek
> On April 14, 2015, 5:50 p.m., Lamarque Souza wrote: > > src/notifybyaudio.cpp, line 89 > > > > > > Should not this patch be followed by another patch that set LoopSound > > flag for Persistant notifications tha

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78923 --- src/knotification.h (line 3)

Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/ --- Review request for KDE Frameworks. Bugs: 346148 https://bugs.kde.org/