Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78840 --- Do you reckon you would be able to work on a unit test for tha

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On April 11, 2015, 8:15 p.m., Lukáš Tinkl wrote: > > This is weird, I've explicitely tested both cases here on Qt 5.4 and they > > worked fine QFileDialog *d = new QFileDialog(parent); d->open(); This one just cannot work, because it will fall to the (parent && !parent->inherits("QWidgetWin

OSX/CI: kdepimlibs fails to build on branch master

Hi folks, after a long time I am finally able to build kmime [1] and thus also kimap and kmbox needed for kdepimlibs! :-D Now I can tackle kdepimlibs again, but the build fails because of a missing template file: --- -- Configuring done CMake Error: Target akonadi_knut_resource Info.plist templ

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78835 --- This is weird, I've explicitely tested both cases here on Qt 5

Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- Review request for KDE Frameworks, David Faure and Lukáš Tinkl. Repositor

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/#review78820 --- src/notifybytaskbar.cpp (line 44)

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/ --- (Updated April 11, 2015, 2:34 p.m.) Review request for KDE Frameworks.

Re: KDEPIM new KDE Jenkins CI help please

On Thursday, April 09, 2015 08:36:27 AM Scarlett Clark wrote: > kdepim fails on my new ci. > 00:19:26 Could not find a package configuration file provided by > 00:19:26 "Qt5WebEngineWidgets" with any of the following names: > 00:19:26 > 00:19:26 Qt5WebEngineWidgetsConfig.cmake > 00:19:26

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

> On April 11, 2015, 1 p.m., Aleix Pol Gonzalez wrote: > > src/notifybytaskbar.cpp, line 46 > > > > > > won't this need finish(notification);? Oh, so it should. Thanks. - David ---

Re: Review Request 123206: Don't try to highlight if there is no spell checker found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123206/ --- (Updated April 11, 2015, 1:17 p.m.) Status -- This change has been m

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/#review78809 --- src/notifybytaskbar.cpp (line 46)

Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote: > > cmake/uriencode.cmake, line 15 > > > > > > I've tried changing this to: > > > > execute_process(COMMAND perl -MURI::Escape -e "print > > u

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote: > > cmake/uriencode.cmake, line 15 > > > > > > I've tried changing this to: > > > > execute_process(COMMAND perl -MURI::Escape -e "print > > u

OSX/CI: qca fails to build on branch qt5 for branch groups (stable-)kf5-qt5

On 11 Apr 2015, at 01:22 , Marko Käning wrote: > I see tons of deprecation warnings for QCA as well as a real error: > > --- > > /Users/marko/WC/KDECI-builds/stable-kf5-qt5/qca/plugins/qca-ossl/qca-ossl.cpp:5719:13: > warning: 'SSL_get_error' is deprecated: first deprecated in OS X 10.7 > [-W

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote: > > cmake/uriencode.cmake, line 15 > > > > > > I've tried changing this to: > > > > execute_process(COMMAND perl -MURI::Escape -e "print > > u