Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 3, 2015, 5:50 p.m.) Review request for KDE Frameworks, Mar

Re: Review Request 123223: Fix bug 344614: kservice splits filename wrong

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/ --- (Updated April 3, 2015, 5:35 p.m.) Review request for KDE Frameworks. C

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

> On April 2, 2015, 10:04 p.m., Dominik Haumann wrote: > > Good catch, maybe we can use QFileInfo::completeBaseName() instead? Good idea. This works and makes the code easier to understand. - Gregor --- This is an automatically generate

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote: > > src/CMakeLists.txt, line 20 > > > > > > It's already committed (but there's been a long time since I hadn't > > build anything), but now I see that

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review78445 --- cmake/uriencode.cmake (line 15)

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On April 3, 2015, 5:35 p.m., Andrius da Costa Ribas wrote: > > src/CMakeLists.txt, line 20 > > > > > > It's already committed (but there's been a long time since I hadn't > > build anything), but now I see that

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review78442 --- src/CMakeLists.txt (line 20)

Jenkins build is back to normal : kinfocenter_master_qt5 #92

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kinfocenter_master_qt5 #91

See Changes: [lueck] update to kf5 -- [...truncated 114 lines...] == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 120393: [kdelibs4support] Kill dead code

> On March 18, 2015, 11:23 p.m., Vishesh Handa wrote: > > I'm all for getting rid of the Nepomuk code. However, I'm not too sure > > about the strigi part. That should still work. > > Hrvoje Senjan wrote: > It does not ;-) > Originally, this review added back the find_package(Strigi) ca