Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216/#review78389 --- hmm just wondering: why does it need to be a QApplication? May

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-04-01 Thread Alex Merry
On Wednesday 01 April 2015 21:39:45 Alex Merry wrote: > This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't > have an issue, and neither does 3.1.3. For reference: http://www.cmake.org/Bug/view.php?id=15101 Alex ___ Kde-framewor

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-04-01 Thread Alex Merry
On Wednesday 01 April 2015 08:59:30 Harald Sitter wrote: > On Tue, Mar 31, 2015 at 9:29 PM, Alex Merry wrote: > > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > >> Problem tldr: target A links library B, A doesn't get the includes of > >> link libraries of B by default. e.g. A links B,

Jenkins build is back to normal : kdeclarative_master_qt5 #202

2015-04-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216/#review78370 --- Cool stuff! - Aleix Pol Gonzalez On April 1, 2015, 7:23 p.m

Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread David Edmundson
> On April 1, 2015, 5:25 p.m., Kai Uwe Broulik wrote: > > Intercept widgets, as in https://git.reviewboard.kde.org/r/122590/ ? I don't think so. That's in framework that ends up in applications, this patch is in the small daemon that runs constantly in the backgroud. - David ---

Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216/#review78367 --- Intercept widgets, as in https://git.reviewboard.kde.org/r/122

Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216/ --- Review request for KDE Frameworks. Repository: kglobalaccel Description

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

2015-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122149/ --- (Updated April 1, 2015, 4:16 p.m.) Status -- This change has been di

Build failed in Jenkins: kdeclarative_master_qt5 #201

2015-04-01 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: kdeclarative_master_qt5 #200

2015-04-01 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 123210: Don't display black square if icon is not set

2015-04-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/ --- (Updated April 1, 2015, 2:06 p.m.) Status -- This change has been ma

Re: Review Request 123210: Don't display black square if icon is not set

2015-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/#review78338 --- Ship it! src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp

Review Request 123210: Don't display black square if icon is not set

2015-04-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Review Request 123206: Don't try to highlight if there is no spell checker found

2015-04-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123206/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-04-01 Thread Harald Sitter
On Tue, Mar 31, 2015 at 9:29 PM, Alex Merry wrote: > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: >> Problem tldr: target A links library B, A doesn't get the includes of >> link libraries of B by default. e.g. A links B, B links karchive, A >> doesn't have access to the karchive header