Re: [Kde-games-devel] Data migration issue

On March 22, 2015 06:19:46 PM David Faure wrote: > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > Too late for KDE Applications 15.04 though now that i think, so maybe we > > actually have to suggest everybody using the migrator to add those extra > > lines? > > OK, that means: >

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 23, 2015, 12:34 a.m.) Status -- This change has been

Review Request 123111: Only add a '/' if the url does not end with one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123111/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: [Kde-games-devel] Data migration issue

El Diumenge, 22 de març de 2015, a les 21:41:02, Albert Astals Cid va escriure: > El Diumenge, 22 de març de 2015, a les 18:19:46, David Faure va escriure: > > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > > Too late for KDE Applications 15.04 though now that i think, so maybe we

Re: [Kde-games-devel] Data migration issue

El Diumenge, 22 de març de 2015, a les 18:19:46, David Faure va escriure: > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > Too late for KDE Applications 15.04 though now that i think, so maybe we > > actually have to suggest everybody using the migrator to add those extra > > lines

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- (Updated March 22, 2015, 8:06 p.m.) Status -- This change has been m

Re: Review Request 123101: Only add "/" to path if really necessary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/#review77923 --- +1 - Mark Gaiser On March 22, 2015, 6:05 p.m., Àlex Fiestas

Review Request 123101: Only add "/" to path if really necessary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review77921 --- Ship it! Ship It! - David Faure On March 22, 2015, 5:25 p.

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 22, 2015, 5:25 p.m.) Review request for KDE Frameworks.

Re: [Kde-games-devel] Data migration issue

On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > Too late for KDE Applications 15.04 though now that i think, so maybe we > actually have to suggest everybody using the migrator to add those extra > lines? OK, that means: --- a/src/lib/util/kdelibs4configmigrator.h +++ b/src/lib/ut

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 22, 2015, 5:18 p.m.) Review request for KDE Frameworks.

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote: > > autotests/kglobalshortcuttest.cpp, lines 424-428 > > > > > > please compare with the other test cases - there are verifications on > > whether kglobalac

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following About why it is needed: see KGlobalShortcutTest::testLoadShortcutFromGlobalSettings: short

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote: > > autotests/kglobalshortcuttest.cpp, lines 424-428 > > > > > > please compare with the other test cases - there are verifications on > > whether kglobalac

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated March 22, 2015, 4:05 p.m.) Review request for KDE Frameworks, Ma

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77912 --- Can you clarify why this is needed? If it is something we alwa

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:07 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, line 266 > > > > > > can I get your time machine? > > https://www.kde.org/announcements/kde-frameworks-5.8.0.php ;-) yes, sure, ple

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 22, 2015, 12:37 p.m.) Review request for KDE Frameworks an

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 394 > > > > > > Do we need the kmt-prefix? Why not just > > KMoreToolsService * service(); > > Gregor Mi wrote: >

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77902 --- autotests/kglobalshortcuttest.cpp (lines 424 - 428)

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77901 --- I doubt the test will work on the CI system as there we don't

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 22, 2015, 7:41 a.m.) Review request for KDE Frameworks and