Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 287 > > > > > > @return, never @returns. > > > > Further, can you be mor verbose? > > > > @return Re

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 15, 2015, 5:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 15, 2015, 5:07 p.m.) Review request for KDE Frameworks and

Review Request 122970: Move added setError method to new JobViewV3 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description

Re: Review Request 122937: Preserve translation domain when merging KXmlGui files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122937/#review77531 --- Makes sense to me. Also did a bit of testing with a few applic

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 287 > > > > > > @return, never @returns. > > > > Further, can you be mor verbose? > > > > @return Re

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 36 > > > > > > Proper doxygen would look like this: The first sentence is always the > > "brief" documentation. > >

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 394 > > > > > > Do we need the kmt-prefix? Why not just > > KMoreToolsService * service(); I am not completely th

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77511 --- src/kmoretools/kmoretools.cpp

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 122926: Add setError method to JobViewV2 interface

> On mar. 15, 2015, 11:10 a.m., Bhushan Shah wrote: > > Umm; this seems to break source compatibilty maybe? For example > > plasma-workspace Plasma/5.2 branch which compiled with older revisions fine > > seems to fail with this commit > > > > 23:07:43 Building CXX object > > applets/systemtra

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 122926: Add setError method to JobViewV2 interface

> On March 15, 2015, 11:10 a.m., Bhushan Shah wrote: > > Umm; this seems to break source compatibilty maybe? For example > > plasma-workspace Plasma/5.2 branch which compiled with older revisions fine > > seems to fail with this commit > > > > 23:07:43 Building CXX object > > applets/systemtr

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

> On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote: > > Without testing anything, I think that this will break QWidget's file > > dialog when set to modal. Iirc this breaks for example the open dialogs in > > qt creator. Yeah, that's the wrong approach, though I'm not sure what the right

Re: Review Request 122926: Add setError method to JobViewV2 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77503 --- Umm; this seems to break source compatibilty maybe? For exampl

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77502 --- I don't think that the patch in it's current form is ok to com

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/#review77498 --- Without testing anything, I think that this will break QWidget