Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 13, 2015, 6:36 vorm.) Review request for KDE Frameworks.

Re: Review Request 122893: Populate KIconDialog on showEvent

> On March 12, 2015, 7:15 p.m., Christoph Feck wrote: > > Ship It! Thinking again, the way you use the eventFilter (for the KIconDialog object), it still will not work with derived classes not recompiled. You need to create a separate (child) object which has the eventFilter method, and "watc

Re: Review Request 122682: Respect KZip::extraField setting also when writing central header entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122682/ --- (Updated March 12, 2015, 11:30 p.m.) Status -- This change has been

Re: New framework: ModemManagerQt

El Dijous, 12 de març de 2015, a les 09:56:06, Jan Grulich va escriure: > Hi all, > > I would like to ask you if you could review ModemManagerQt library > (currently as libmm-qt). I want to make it as framework before KF5 5.9.0 > gets released and make Plasma 5.3 depend on it, otherwise we would h

Re: KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

El Dijous, 12 de març de 2015, a les 14:03:09, Jan Kundrát va escriure: > Hi, > kdeclarative doesn't build on Qt 5.2 since commit > 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on > QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged > almost two mon

Jenkins build is back to normal : kitemmodels_master_qt5 #78

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kitemmodels_stable_qt5 #23

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [plasma-devel] Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

On Thu, Mar 12, 2015 at 12:39:30AM +0100, David Edmundson wrote: >On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza wrote: > > Hi all,A > Following the obsolete action, could someone mark "Network Management" > product as obsolete too? It is related to old Plasma NM 0.9.0.x ser

Re: solid bugzilla product marked obsolete

"Network Management" product is already closed for new bugs and the description points to "plasma-nm" product. Jonathan On Wed, Mar 11, 2015 at 08:37:50PM -0300, Lamarque Souza wrote: >Hi all,A >Following the obsolete action, could someone mark "Network Management" >product as obs

Build failed in Jenkins: kitemmodels_master_qt5 #77

See Changes: [steveire] KSPM: Fix setting selection state after source reset. [steveire] Remove needless metatype registration. [steveire] Remove .data() accessor from QPointer use. [steveire] KDPM: Handle moves reported by the sourc

Build failed in Jenkins: kitemmodels_stable_qt5 #22

See Changes: [steveire] KSPM: Fix setting selection state after source reset. [steveire] Remove needless metatype registration. [steveire] Remove .data() accessor from QPointer use. [steveire] KDPM: Handle moves reported by the sourc

Review Request 122926: Add setError method to JobViewV2 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Status -- This change has been m

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- Ship it! Ship It! - Christoph Feck On March 12, 2015, 7:10

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 12, 2015, 7:10 nachm.) Review request for KDE Frameworks.

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 7 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 7:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 122886: QML-only KCM base

> On March 10, 2015, 11:30 a.m., Marco Martin wrote: > > src/quickaddons/configmodule.h, line 43 > > > > > > I don't particularly like the KDeclarative namespace here since the > > library is called QuickAddons,

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 2:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and

Review Request 122918: revert 2ee76f0 to fix QtQuickControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- Review request for KDE Frameworks and Frederik Gladhorn. Bugs: 345002

Re: New framework: ModemManagerQt

Looks good to me. 2 minor comments. All classes are namespaced, but generictypes.h is not. Given these names could easily clash with something else and are publicly included, it might be worth putting them in the same namespace. ModemManager::ModemMessaging::messages can be const? David ​

KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

Hi, kdeclarative doesn't build on Qt 5.2 since commit 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged almost two months ago. Seems that I should configure some breakage notifications from the Z

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/#review77350 --- Small nitpick. src/knotification.cpp

Re: Review Request 122876: Delay notifications a bit on Plasma startup

> On March 12, 2015, 8:48 a.m., Martin Gräßlin wrote: > > timer looks wrong to me, too. Not because it's ugly, but because Plasma > > notifications will not go above the splash screen. The fallback might be > > ugly, but as I have seen: it goes above the splash screen. > > > > Thus I suggest t

New framework: ModemManagerQt

Hi all, I would like to ask you if you could review ModemManagerQt library (currently as libmm-qt). I want to make it as framework before KF5 5.9.0 gets released and make Plasma 5.3 depend on it, otherwise we would have to release it again together with Plasma and wait three more months. The on

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- (Updated March 11, 2015, 2:41 p.m.) Status -- This change has been m

New framework: BluezQt

Hi all, BluezQt is a wrapper library for Bluez 5 DBus API. It will be used in Bluedevil as a replacement for libbluedevil. It is currently in playground (playground/libs/bluez-qt). It should be a Tier 1 framework (only depends on Qt libs). The code should follow all framework policies and the bu

Re: New framework: BluezQt

I'm forwarding the reply here too: > The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how > about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not a right thing. > The h

Re: Review Request 122876: Delay notifications a bit on Plasma startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122876/#review77324 --- timer looks wrong to me, too. Not because it's ugly, but becau

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 11, 2015, 1:46 p.m.) Review request for KDE Frameworks and

Review Request 122890: Make KMessageWidget animation non pixelated with high DPR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122890/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget