Re: Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122900/#review77322 --- Ship it! It even works! :D src/kpluginselector.h

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated mar. 12, 2015, 4:37 a.m.) Review request for KDE Frameworks and

Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

> On mar. 9, 2015, 11:20 a.m., Martin Klapetek wrote: > > Ship It! > > Martin Klapetek wrote: > Actually wait, StandardEvents should have standard icons, why would you > need to change them? > > Albert Vaca Cintora wrote: > They don't have a standard, default icon: you have to specify

Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotif

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77320 --- src/kicondialog.cpp

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza wrote: > Hi all, > > Following the obsolete action, could someone mark "Network Management" > product as obsolete too? It is related to old Plasma NM 0.9.0.x series, > which is now unmaintained. > > I've removed "open for bugs" option on that produ

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

Hi all, Following the obsolete action, could someone mark "Network Management" product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM, Al

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 11, 2015, 11:08 p.m.) Status -- This change has been

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 11, 2015, 11:06 p.m.) Review request for KDE Frameworks, E

Re: solid bugzilla product marked obsolete

El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va escriure: > I've labelled the solid bugzilla product as obsolete and added a comment to > any bugs that it's for kdelibs4 code which is now in maintenance mode. > Replacement products are bluedevil, powerdevil, plasma-nm and > fra

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 11, 2015, 10:56 nachm.) Review request for KDE Frameworks.

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77316 --- Moved to knewstuff: https://git.reviewboard.kde.org/r/122910/

Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting.

solid bugzilla product marked obsolete

I've labelled the solid bugzilla product as obsolete and added a comment to any bugs that it's for kdelibs4 code which is now in maintenance mode. Replacement products are bluedevil, powerdevil, plasma-nm and frameworks-solid. Jonathan ___ Kde-frameworks

Re: [kde-frameworks-devel] Review request: QBluez

On Mon, Feb 16, 2015 at 10:40:44AM +0100, David Rosca wrote: > Hi all, > I'd like to ask for a review of the QBluez library [1]. Looks like you've been working hard :) The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez ? The headers get installed int

Re: New framework: BluezQt

On Tue, Mar 10, 2015 at 10:12:31PM +0100, David Rosca wrote: > BluezQt is a wrapper library for Bluez 5 DBus API. It will be > used in Bluedevil as a replacement for libbluedevil. > It is currently in playground (playground/libs/bluez-qt). > > It should be a Tier 1 framework (only depends on Qt li

Re: [kde-frameworks-devel] Review request: QBluez

On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell wrote: > The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how > about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 11, 2015, 5:05 p.m.) Review request for KDE Frameworks and

Review Request 122908: Fix segfaults due to missing screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122908/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77309 --- src/quickaddons/CMakeLists.txt

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.h, line 373 > > > > > > I guess you copy and pasted all these. > > KConfigXT isn't relevant at all here. yes, is pretty

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- src/quickaddons/configmodule.h

Re: Review Request 122886: QML-only KCM base

> On March 10, 2015, 11:33 a.m., Marco Martin wrote: > > src/quickaddons/configmodule.cpp, line 167 > > > > > > I didn't test things that need authentication yet (if some good soul > > ports a module that uses i

Re: Review Request 122888: Port the look and feel KCM to the qml only version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/#review77300 --- Ship it! (when other stuff is merged obviously) - David Edmu

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/#review77299 --- +1 looks good to me. src/kcmoduleqml.cpp

Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

> On March 9, 2015, 11:20 a.m., Martin Klapetek wrote: > > Ship It! > > Martin Klapetek wrote: > Actually wait, StandardEvents should have standard icons, why would you > need to change them? > > Albert Vaca Cintora wrote: > They don't have a standard, default icon: you have to specify