Re: KPeople part of KDE Frameworks

On Wed, Mar 4, 2015 at 2:00 PM, Michael Pyne wrote: > On Tue, March 3, 2015 08:29:16 Marko Käning wrote: >> > With that said, kdesrc-build *will* ignore modules that have a defined >> > branch of "" (i.e. empty) in logical-module-structure, so if a module >> > simply should not be built for a give

Re: Review Request 122764: Adding missing licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/ --- (Updated March 4, 2015, 1:46 a.m.) Status -- This change has been ma

Re: Review Request 122795: Fix crashes when attempting to load invalid package

> On March 3, 2015, 11:39 p.m., Aleix Pol Gonzalez wrote: > > Would it maybe be possible to get a unit test for the applet loading? I think all the crashes I got were due to https://git.reviewboard.kde.org/r/122733/. Now that that is fixed, the mainscript is always found. I'll try and create a

Re: KPeople part of KDE Frameworks

On Tue, March 3, 2015 08:29:16 Marko Käning wrote: > > With that said, kdesrc-build *will* ignore modules that have a defined > > branch of "" (i.e. empty) in logical-module-structure, so if a module > > simply should not be built for a given branch-group my recommendation > > would be to define th

Re: [Kde-games-devel] Data migration issue

Hi, I noticed a problem with the data migration in the kdegames transition from kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for advice. In short, when the migration is run after the QCoreApplication is created, the migrated config is not used but the default values.

Re: Review Request 122795: Fix crashes when attempting to load invalid package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76973 --- Would it maybe be possible to get a unit test for the applet l

Re: Review Request 122796: Print a warning message when loading an invalid KDeclarative::QmlObject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122796/#review76972 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3, 2015, 8

Build failed in Jenkins: khtml_stable_qt5 #39

See Changes: [aiacovitti] Add $ -- [...truncated 640 lines...] [ 48%] Building CXX object src/CMakeFiles/KF5KHtml.dir/editing/htmlediting_impl.cpp.o [ 49%] [ 49%] Building CXX object src/CMakeFiles/K

Build failed in Jenkins: khtml_master_qt5 #192

See Changes: [aiacovitti] Add $ -- [...truncated 631 lines...] [ 48%] Building CXX object src/CMakeFiles/KF5KHtml.dir/editing/htmlediting_impl.cpp.o [ 49%] Building CXX object src/CMakeFiles/KF5KHtml

Review Request 122796: Print a warning message when loading an invalid KDeclarative::QmlObject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122796/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 122795: Fix crashes when attempting to load invalid package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 121317: Add JSON metadata to the kded modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated March 3, 2015, 7:31 p.m.) Status -- This change has been ma

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 99 > > > > > > returning here is weird. ah, you do it because otherwise the QQuickWindow would be out of scope. -

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobject.cpp, line 199 > > > > > > question, where does > > > > KPackage/GenericQML come from? it's an internal type in kpack

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 122733: Fix path traversal checks in KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- (Updated March 3, 2015, 5:53 p.m.) Status -- This change has been ma

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- src/kdeclarative/qmlobject.h

Re: Review Request 122793: Fix KUrlNavigator with high DPI pixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122793/#review76957 --- +1 - Aleix Pol Gonzalez On March 3, 2015, 5:37 p.m., David

Re: Review Request 122792: Add test app for showing KUrlNavigator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122792/#review76956 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3, 2015, 5

Re: Review Request 122792: Add test app for showing KUrlNavigator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122792/#review76954 --- tests/kencodingfiledialogtest_gui.cpp

Review Request 122792: Add test app for showing KUrlNavigator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122792/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 122793: Fix KUrlNavigator with high DPI pixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122793/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #1037

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122788/ --- (Updated March 3, 2015, 1:31 p.m.) Status -- This change has been ma

Re: Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122788/#review76949 --- Ship it! Ship It! - Luigi Toscano On March 3, 2015, 1:09 p

Re: Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

> On March 3, 2015, 1:13 p.m., Luigi Toscano wrote: > > Does it mean that it's not working right now? Right, it does not. The symmetrical patch on kdelibs4support has: kdelibs4support_encode_uri(DocBookXML4_DTD_DIR) http://quickgit.kde.org/?p=kdelibs4support.git&a=commitdiff&h=315e660886ea3809db

Re: Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122788/#review76946 --- Does it mean that it's not working right now? - Luigi Toscano

New build dependency in KF5

Hi, My build had been failing for the last days, I just realized that the issue was that we're now depending on URI/Escape.pm in order to encode uri's from cmake in kdelibs4support and kdoctools. Was this intentional? Aleix ___ Kde-frameworks-devel mail

Re: New build dependency in KF5

On Tuesday 03 of March 2015 13:06:19 Aleix Pol wrote: > Hi, > My build had been failing for the last days, I just realized that the > issue was that we're now depending on URI/Escape.pm in order to encode > uri's from cmake in kdelibs4support and kdoctools. > > Was this intentional? Yes, it is. Y

Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122788/ --- Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctool

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 10:14 a.m.) Review request for KDE Frameworks and

Re: Review Request 122733: Fix path traversal checks in KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76941 --- Ship it! Ship It! - Marco Martin On Feb. 26, 2015, 7:34 p.