Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-02-22 Thread Matthew Dawson
> On Feb. 21, 2015, 3:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Review Request 122682: Respect KZip::extraField setting also when writing central header entries

2015-02-22 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122682/ --- Review request for KDE Frameworks and David Faure. Repository: karchive

Re: Review Request 122576: Introduce KMoreTools

2015-02-22 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 11:24 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

2015-02-22 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 8:34 p.m.) Review request for KDE Frameworks, Dom

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-02-22 Thread David Faure
> On Feb. 21, 2015, 8:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-02-22 Thread David Faure
> On Feb. 21, 2015, 8:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122576: Introduce KMoreTools

2015-02-22 Thread Albert Astals Cid
> On feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: > > src/kmoretools/kmoretoolsconfigdialog.h, line 27 > > > > > > Why is a non private header including a private header? > > Gregor Mi wrote: > kmoretoo

Re: Review Request 122576: Introduce KMoreTools

2015-02-22 Thread Gregor Mi
> On Feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: > > src/kmoretools/kmoretoolsconfigdialog.h, line 27 > > > > > > Why is a non private header including a private header? kmoretoolsconfigdialog.h should be

Re: Review Request 122576: Introduce KMoreTools

2015-02-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76422 --- src/kmoretools/kmoretoolsconfigdialog.h