Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Do

Re: Review request: QBluez

El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: > Hi all, > I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new

Re: Review Request 122576: Introduce KMoreTools

> On feb. 16, 2015, 10:28 p.m., Albert Astals Cid wrote: > > You're missing lots of const in your getters and const & in your params > > Gregor Mi wrote: > Thx for the hint, I added now lots of const in the getters. > With "const & in params" are referring to QString parameters? I though

Re: Review Request 122576: Introduce KMoreTools

> On Feb. 16, 2015, 10:28 p.m., Albert Astals Cid wrote: > > You're missing lots of const in your getters and const & in your params Thx for the hint, I added now lots of const in the getters. With "const & in params" are referring to QString parameters? I thought they were reference counted.

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:36 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:30 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76158 --- You're missing lots of const in your getters and const & in yo

Review request: QBluez

Hi all, I'd like to ask for a review of the QBluez library [1]. QBluez is a Qt 5 wrapper for Bluez 5 DBus API. I have started working on it as a GSoC 2014 project. It is intended to be a libbluedevil replacement, main difference being that every DBus call is made asynchronous. It also exposes more

Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated Feb. 16, 2015, 9:08 p.m.) Review request for Kate and KDE Framew

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/ --- (Updated Feb. 16, 2015, 6:29 p.m.) Status -- This change has been ma

Build failed in Jenkins: kconfig_stable_qt5 #21

See Changes: [guy.maurel] at KDesktopFile::locateLocal, correct the expression of the if statement which was always TRUE -- [...truncated 324 lines...] [ 44%] Building CXX object autotests/CMakeFil

Jenkins build is unstable: plasma-framework_master_qt5 » All,LINBUILDER #1005

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

> On Feb. 3, 2015, 9:33 p.m., David Faure wrote: > > src/currency.cpp, line 672 > > > > > > well then we still have a problem if the CurrencyCategory is being > > deleted before this job finishes. Can this happe

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/#review76145 --- Ship it! Thanks. Remember to adjust the commit log, in case i

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/#review76136 --- Ship it! Looks good, thank you! src/knotifyconfig.cpp

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

> On Feb. 3, 2015, 9:33 p.m., David Faure wrote: > > src/currency.cpp, line 672 > > > > > > well then we still have a problem if the CurrencyCategory is being > > deleted before this job finishes. Can this happe

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/ --- (Updated Feb. 16, 2015, 3:50 p.m.) Review request for KDE Frameworks, Cor

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122579/ --- (Updated Feb. 16, 2015, 2:24 p.m.) Status -- This change has been ma

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76121 --- +1 for the approach I assume it's used to check whether a QAc

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 16, 2015, 12:25 nachm.) Review request for KDE Frameworks,

Re: Review Request 122562: Add method for converting from QVariant to base64

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122562/ --- (Updated Feb. 16, 2015, 1:22 p.m.) Status -- This change has been di

Re: Review Request 122562: Add method for converting from QVariant to base64

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122562/#review76118 --- src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 16, 2015, 11:56 vorm.) Review request for KDE Frameworks, D

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76116 --- we should investigate whether the argument for using a widget

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76117 --- src/kglobalaccel.cpp

Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Re

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76114 --- src/CMakeLists.txt

Jenkins build is back to stable : kservice_stable_qt5 #40

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kservice_master_qt5 #240

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122487: Reorder member variables to reduce memory usage.

On Wednesday 11 February 2015 13:52:36 Thiago Jung Bauermann wrote: > Volker Krause wrote: > >> On Feb. 8, 2015, 8:45 p.m., David Faure wrote: > >> > Which magic tool did you come up with this time, to detect such things? > >> > > >> > :-) > >> > >> Aleix Pol Gonzalez wrote: > >> +1 :D I too