Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/#review75897 --- +1 and +1 to the script. - Aleix Pol Gonzalez On Feb. 12, 2

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75895 --- Ship it! Ship It! - Alex Richardson On Feb. 11, 2015, 5:45

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/#review75893 --- Note: I can easily script this to run on all frameworks. Pleas

Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75879 --- Ship it! LGTM. - Kevin Funk On Feb. 11, 2015, 5:45 p.m., A

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-11 Thread Albert Astals Cid
El Dimecres, 11 de febrer de 2015, a les 20:00:38, Marko Käning va escriure: > Hi Albert, > > On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote: > > Exactly, whoever added that code either needs to find a Qt 5.3 way to do > > the same, or bump the requirement. > who is in charge of kde-baseapps? >

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-11 Thread Jeremy Whiting
The offending commit was from Arjun AK, I've e-mailed him and cc'ed kde-core-devel to either bump kde-baseapps Qt requirement or revert/workaround that use of the enumeration that is new in Qt 5.4. On Wed, Feb 11, 2015 at 12:00 PM, Marko Käning wrote: > Hi Albert, > > On 10 Feb 2015, at 23:17 ,

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-11 Thread Marko Käning
Hi Albert, On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote: > Exactly, whoever added that code either needs to find a Qt 5.3 way to do the > same, or bump the requirement. who is in charge of kde-baseapps? I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the project set

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-02-11 Thread Thiago Jung Bauermann
Volker Krause wrote: > >> On Feb. 8, 2015, 8:45 p.m., David Faure wrote: >> > Which magic tool did you come up with this time, to detect such things? >> > :-) >> >> Aleix Pol Gonzalez wrote: >> +1 :D I too want to know! > > It's still very much WIP, the code is in kde:scratch/vkrause/elf-dis

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/ --- (Updated Feb. 11, 2015, 6:45 p.m.) Review request for KDE Frameworks, Ale

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #994

2015-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Martin Klapetek
> On Feb. 11, 2015, 4:35 p.m., Kevin Funk wrote: > > src/services/kplugininfo.cpp, line 574 > > > > > > Style: Space after keyword, more below. > > Kevin Funk wrote: > Wrong line, sorry. But you know what I

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75866 --- Ship it! Code looks good to me. Unit test would be *very* goo

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
> On Feb. 11, 2015, 3:35 p.m., Kevin Funk wrote: > > src/services/kplugininfo.cpp, line 574 > > > > > > Style: Space after keyword, more below. Wrong line, sorry. But you know what I mean :) - Kevin

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75865 --- +1 from me - Marco Martin On Feb. 10, 2015, 5:18 p.m., Alei

Re: Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122526/ --- (Updated Feb. 11, 2015, 2:08 p.m.) Status -- This change has been ma

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- (Updated Feb. 11, 2015, 2:04 p.m.) Status -- This change has been ma

Re: New framework: KXmlRpcClient

2015-02-11 Thread Aleix Pol
On Thu, Jan 8, 2015 at 6:08 PM, Daniel Vrátil wrote: > Hi all, > > KXmlRpcClient provides a complete XMLRPC client for applications to use. It's > used most notably by DrKonqi to talk to b.k.o. It's the first framework split > from kdepimlibs that we feel is ready to be shipped with KDE Frameworks

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #993

2015-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122526/#review75852 --- find-modules/FindQtWaylandScanner.cmake

Re: Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122526/#review75850 --- Ship it! Works for my testcase in any case! - Boudewijn Remp

Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122526/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #991

2015-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/#review75847 --- +1 - David Edmundson On Feb. 11, 2015, 12:11 p.m., Aleix Po

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- (Updated Feb. 11, 2015, 1:11 p.m.) Review request for KDE Frameworks, KDE

Jenkins build is back to normal : ksshaskpass_master_qt5 #20

2015-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ksshaskpass_master_qt5 #19

2015-02-11 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUIL