Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

> On Jan. 29, 2015, 7:46 a.m., David Faure wrote: > > Shouldn't splitArgs be fixed instead? After all a real shell would not > > split on that character, would it? > > Albert Astals Cid wrote: > That is indeed a good question. Bash doesn't seem to need the quotes, but > i don't know about

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

> On gen. 29, 2015, 7:46 a.m., David Faure wrote: > > Shouldn't splitArgs be fixed instead? After all a real shell would not > > split on that character, would it? That is indeed a good question. Bash doesn't seem to need the quotes, but i don't know about other shells, and i figured out addin

Review Request 122313: Expose to world whether KPty has been built with utempter library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/ --- Review request for KDE Frameworks and David Faure. Repository: kpty Des

Re: Supporting MSVC2010 in ktexteditor framework

On Thursday 29 January 2015 11:56:51 Kevin Ottens wrote: > On Thursday 29 January 2015 09:49:58 Ivan Čukić wrote: > > Hi all, > > > > So, the thread died out again. > > > > Who is in favour of the following: > > - Require MSVC10 like (aka status quo) > > - Require MSVC11 > > - Require MSVC12 > >

Re: Review Request 122206: [kio] Make tests optional

> On Jan. 23, 2015, 8:58 p.m., David Faure wrote: > > Not sure why this is suddenly triggering many philosophical discussions > > about what users should be doing (IMHO, give them choice, this is > > opensource). > > Similar changes have been done in most other frameworks long ago, this is > >

Re: Review Request 120185: Look for kdesu in the correct location

> On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: > > any updates on that? > > > > here the patch works correctly after i make kdesu to be installed under > > CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR > > > > I would push this asap, since kdesu in Plasma 5 is

Re: Review Request 120040: Install kdesu under bin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Jan. 29, 2015, 3:16 p.m.) Status -- This change has been di

Re: Review Request 120185: Look for kdesu in the correct location

> On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: > > any updates on that? > > > > here the patch works correctly after i make kdesu to be installed under > > CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR > > > > I would push this asap, since kdesu in Plasma 5 is

Re: Review Request 120185: Look for kdesu in the correct location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review74983 --- any updates on that? here the patch works correctly after i m

Re: Supporting MSVC2010 in ktexteditor framework

> My opinion is still the same on this matter: VS2012 (aka MSVC11). I guessed as much. Just wanted to get the ball rolling again so that we can reach a decision, instead of just talking about it. I also think that (while insufficient for the most fun things of c++11) MSVC11 (VS12) is the currentl

Build failed in Jenkins: kde-baseapps_master_qt5 #216

See Changes: [emmanuelpescosta099] Revert commit 0c6c76b038e868e225f7816fae39635d472bce0a and make the -- [...truncated 3048 lines...]

Re: reviving make uninstall?

On Thu, Jan 29, 2015 at 12:46 PM, Sebastian Kügler wrote: > On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote: > > > It's only used by developers anyways, so why bother? If it makes life > > > simpler > > > for devs, it should be there, no? Normal users who might get confused > by > >

Re: reviving make uninstall?

On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote: > > It's only used by developers anyways, so why bother? If it makes life > > simpler > > for devs, it should be there, no? Normal users who might get confused by > > it > > won't ever run make (un)install either, no? > > +1. I found my

Re: Supporting MSVC2010 in ktexteditor framework

On Thursday 29 January 2015 09:49:58 Ivan Čukić wrote: > Hi all, > > So, the thread died out again. > > Who is in favour of the following: > - Require MSVC10 like (aka status quo) > - Require MSVC11 > - Require MSVC12 My opinion is still the same on this matter: VS2012 (aka MSVC11). Regards. --

Re: Supporting MSVC2010 in ktexteditor framework

+1 for VC12 (I'm using msvc 2013) -- Andrius. 2015-01-29 6:49 GMT-02:00 Ivan Čukić : > Hi all, > > So, the thread died out again. > > Who is in favour of the following: > - Require MSVC10 like (aka status quo) > - Require MSVC11 > - Require MSVC12 > > (it would be nice to get the input from kde

Re: Supporting MSVC2010 in ktexteditor framework

Hi all, So, the thread died out again. Who is in favour of the following: - Require MSVC10 like (aka status quo) - Require MSVC11 - Require MSVC12 (it would be nice to get the input from kde windows guys as well) Cheerio, Ivan On 17 November 2014 at 14:41, Kai Uwe Broulik wrote: > >> > > -

Re: Review Request 122206: [kio] Make tests optional

> On Jan. 23, 2015, 9:58 p.m., David Faure wrote: > > Not sure why this is suddenly triggering many philosophical discussions > > about what users should be doing (IMHO, give them choice, this is > > opensource). > > Similar changes have been done in most other frameworks long ago, this is > >