Build failed in Jenkins: kde-baseapps_master_qt5 #208

2015-01-24 Thread KDE CI System
See Changes: [emmanuelpescosta099] Port ConfigurePreviewPluginDialog away from KLibrary, KIO::NetAccess::del and ThumbCreatorV2 [emmanuelpescosta099] Removed old (<= 4.6) settings upgrading code (jpegrotatedthumbnail to jpegthumbna

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-24 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74671 --- The overall idea is sound. Just a few issues: autotests/kco

Re: Review Request 122235: --version: Change "KDE Development Platform" to "KDE Frameworks"

2015-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/#review74668 --- Ship it! I agree :-) - David Faure On Jan. 24, 2015, 2:36

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74666 --- Makes sense to me, need someone else to approve though, not a

Review Request 122235: --version: Change "KDE Development Platform" to "KDE Frameworks"

2015-01-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs4su

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-24 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Jan. 24, 2015, 1:27 nachm.) Status -- This change has been

Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.

2015-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/ --- (Updated Jan. 24, 2015, 12:02 p.m.) Status -- This change has been m

Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.

2015-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/#review74655 --- Ship it! Ship It! - Alex Merry On Jan. 21, 2015, 9:03 a.m.