Jenkins build became unstable: kservice_stable_qt5 #26

2015-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122194: Initialise all member variables

2015-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/#review74512 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 21, 2015, 1

Jenkins build is back to normal : kded_master_qt5 #91

2015-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kded_stable_qt5 #12

2015-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kded_master_qt5 #90

2015-01-21 Thread KDE CI System
See Changes: [shafff] qstring optimizations -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: kded_stable_qt5 #11

2015-01-21 Thread KDE CI System
See Changes: [shafff] qstring optimizations -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace

Re: Review Request 122177: some minor fixes for windows

2015-01-21 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/ --- (Updated Jan. 21, 2015, 10:56 p.m.) Status -- This change has been m

Re: Review Request 122177: some minor fixes for windows

2015-01-21 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/#review74509 --- Ship it! Ship It! - Allen Winter On Jan. 21, 2015, 10:39 p

Re: Review Request 122177: some minor fixes for windows

2015-01-21 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/ --- (Updated Jan. 21, 2015, 10:39 nachm.) Review request for KDE Frameworks.

Re: Review Request 122194: Initialise all member variables

2015-01-21 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/#review74508 --- Ship it! Ship It! - Milian Wolff On Jan. 21, 2015, 10:19 p

Review Request 122194: Initialise all member variables

2015-01-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: KF 5.6 changelog

2015-01-21 Thread Albert Astals Cid
El Dimarts, 20 de gener de 2015, a les 13:49:14, Marco Martin va escriure: > On Thursday 08 January 2015, Daniel Vrátil wrote: > > On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: > > > With cookies to Kai Uwe Broulik for using "CHANGELOG:" in most of his > > > commits! > > > > The KPa

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-21 Thread Martin Gräßlin
> On Jan. 21, 2015, 10:07 a.m., Martin Gräßlin wrote: > > ping - do we want this approach to go in? > > Thomas Lübking wrote: > I've two concerns about this. > 1. the name "icons" implies "several" (it's unfortunate that ::icon isn't > ::iconPixmap) - maybe "windowIcon()" or similar >

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-21 Thread Thomas Lübking
> On Jan. 21, 2015, 9:07 vorm., Martin Gräßlin wrote: > > ping - do we want this approach to go in? I've two concerns about this. 1. the name "icons" implies "several" (it's unfortunate that ::icon isn't ::iconPixmap) - maybe "windowIcon()" or similar 2. the behavior how an icon is build up fro

Re: Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

2015-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122180/#review74480 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 21, 2015, 3

Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

2015-01-21 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122182/ --- Review request for KDE Frameworks. Repository: kunitconversion Descript

Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-01-21 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- Review request for KDE Frameworks. Bugs: 340819 https://bugs.kde.org/

Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

2015-01-21 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122180/ --- Review request for KDE Frameworks. Repository: kunitconversion Descript

Review Request 122181: [KUnitConversion] UnitCategory convert: Call UnitCategoryPrivate instead of duplicating it

2015-01-21 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122181/ --- Review request for KDE Frameworks. Repository: kunitconversion Descript

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #965

2015-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- (Updated Jan. 21, 2015, 12:38 p.m.) Status -- This change has been m

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74471 --- Ship it! Ship It! - David Faure On Jan. 21, 2015, 10:57 a.

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- (Updated Jan. 21, 2015, 10:57 a.m.) Review request for KDE Frameworks.

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 20, 2015, 4:16 p.m., David Faure wrote: > > src/kcmoduleproxy.cpp, line 99 > > > > > > ... while this line is happy with dots. > > Hugo Pereira Da Costa wrote: > ok. Got it now. Thanks ! > > Hugo P

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 20, 2015, 4:16 p.m., David Faure wrote: > > src/kcmoduleproxy.cpp, line 99 > > > > > > ... while this line is happy with dots. > > Hugo Pereira Da Costa wrote: > ok. Got it now. Thanks ! > > Hugo P

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread David Faure
> On Jan. 20, 2015, 4:16 p.m., David Faure wrote: > > src/kcmoduleproxy.cpp, line 99 > > > > > > ... while this line is happy with dots. > > Hugo Pereira Da Costa wrote: > ok. Got it now. Thanks ! > > Hugo P

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 20, 2015, 4:16 p.m., David Faure wrote: > > src/kcmoduleproxy.cpp, line 99 > > > > > > ... while this line is happy with dots. > > Hugo Pereira Da Costa wrote: > ok. Got it now. Thanks ! > > Hugo P

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 20, 2015, 4:16 p.m., David Faure wrote: > > src/kcmoduleproxy.cpp, line 99 > > > > > > ... while this line is happy with dots. > > Hugo Pereira Da Costa wrote: > ok. Got it now. Thanks ! Stupid que

Jenkins build is back to stable : kwindowsystem_stable_qt5 » All,LINBUILDER #17

2015-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/#review74461 --- Another approach would be a base class for such daemons, with

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/#review74460 --- ping - do we want this approach to go in? - Martin Gräßlin

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/ --- (Updated Jan. 21, 2015, 10:06 a.m.) Review request for KDE Frameworks and

Review Request 122179: kded: port to KDEDModule::moduleForMessage

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122179/ --- Review request for KDE Frameworks and Kevin Ottens. Repository: kded De

Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/ --- Review request for KDE Frameworks and Kevin Ottens. Repository: kdbusaddo

Re: Review Request 122144: Add new overload to KWindowSystem::icon

2015-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122144/ --- (Updated Jan. 21, 2015, 8:58 a.m.) Status -- This change has been ma

Re: Review Request 122140: Support reading IconPixmap and IconMask from WM_HINTS in NETWinInfo

2015-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122140/ --- (Updated Jan. 21, 2015, 8:58 a.m.) Status -- This change has been ma