Re: Review Request 122140: Support reading IconPixmap and IconMask from WM_HINTS in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122140/ --- (Updated Jan. 20, 2015, 8:53 a.m.) Review request for KDE Frameworks. C

Re: Move thumbnail kioslave and thumbcreator service type to kio?

On Sun, Jan 18, 2015 at 2:38 PM, David Narvaez wrote: > Coincidentially, I am transplanting a protocol into KIO right now, so > I can do this move also. So this transplant required some heavier porting to KF5 and now I have a couple of questions about how to post this for review. Should I: A) 1)

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

> On Jan. 19, 2015, 6:08 p.m., David Faure wrote: > > That's one option, and a good one for compat. > > > > The other option is to change the callers to pass a single dash instead, > > then Qt will process such options automatically - right? > > Aleix Pol Gonzalez wrote: > Yes, but then we

Re: Review Request 122105: Fix KgDifficulty saving on app close

El Dilluns, 19 de gener de 2015, a les 21:15:42, David Faure va escriure: > On Monday 19 January 2015 19:54:46 Albert Astals Cid wrote: > > El Dilluns, 19 de gener de 2015, a les 09:02:07, David Faure va escriure: > > > On Saturday 17 January 2015 21:48:29 Albert Astals Cid wrote: > > > > KF5 peopl

Re: Review Request 122105: Fix KgDifficulty saving on app close

On Monday 19 January 2015 19:54:46 Albert Astals Cid wrote: > El Dilluns, 19 de gener de 2015, a les 09:02:07, David Faure va escriure: > > On Saturday 17 January 2015 21:48:29 Albert Astals Cid wrote: > > > KF5 people: Is this something worth mentioning on the porting notes or > > > using KSharedC

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

> On Jan. 19, 2015, 5:08 p.m., David Faure wrote: > > That's one option, and a good one for compat. > > > > The other option is to change the callers to pass a single dash instead, > > then Qt will process such options automatically - right? > > Aleix Pol Gonzalez wrote: > Yes, but then we

Re: Review Request 122105: Fix KgDifficulty saving on app close

El Dilluns, 19 de gener de 2015, a les 09:02:07, David Faure va escriure: > On Saturday 17 January 2015 21:48:29 Albert Astals Cid wrote: > > KF5 people: Is this something worth mentioning on the porting notes or > > using KSharedConfig::openConfig from a static destructor is a bit of a > > corner

Re: Review Request 122105: Fix KgDifficulty saving on app close

> On gen. 19, 2015, 2:43 p.m., Kevin Funk wrote: > > Can't you `Q_ASSERT(qApp)` in `KSharedConfig::openConfig()` in order to > > make sure people don't do that? There's already a warning. - Albert --- This is an automatically generated

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

> On Jan. 19, 2015, 6:08 p.m., David Faure wrote: > > That's one option, and a good one for compat. > > > > The other option is to change the callers to pass a single dash instead, > > then Qt will process such options automatically - right? Yes, but then we can't integrate them in our code, o

Re: OSX/CI: kdeclarative fails to build on branch master

On 12 Jan 2015, at 22:26 , Marko Käning wrote: > So, if I do install libepoxy on the OSX/CI system I get this: > --- > [ 94%] Building CXX object > src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/mimedatabase.cpp.o > Building CXX object > src/qmlcontrols/kquickco

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122149/#review74347 --- That's one option, and a good one for compat. The other optio

Re: Split kde-baseapps?

On Mon, Jan 19, 2015 at 3:05 AM, David Faure wrote: > I thought kio-about was going into kio-extras? Indeed, I just realized. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Re: Review Request 122144: Add new overload to KWindowSystem::icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122144/#review74335 --- Ship it! Ship It! - Thomas Lübking On Jan. 19, 2015, 1:45

Re: Review Request 122140: Support reading IconPixmap and IconMask from WM_HINTS in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122140/#review74333 --- Ship it! src/netwm.h

Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122149/ --- Review request for KDE Frameworks and David Faure. Repository: kde-cli-to

Re: Review Request 122105: Fix KgDifficulty saving on app close

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105/#review74330 --- Can't you `Q_ASSERT(qApp)` in `KSharedConfig::openConfig()` in

Re: Review Request 122086: Add new method KWindowSystem::icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/ --- (Updated Jan. 19, 2015, 2:50 p.m.) Review request for KDE Frameworks. C

Re: Review Request 122144: Add new overload to KWindowSystem::icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122144/ --- (Updated Jan. 19, 2015, 2:45 p.m.) Review request for KDE Frameworks. C

Re: Review Request 122086: Add new method KWindowSystem::icons

> On Jan. 16, 2015, 5:13 p.m., Thomas Lübking wrote: > > Wrt the other patches, using NETIcon over there, the requirement in KWin > > and likely libtaskbar (ie. keep this in sync): > > What do you think about extending the API by allowing to optionally feed in > > the required elements? > > >

Review Request 122144: Add new overload to KWindowSystem::icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122144/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D

Re: Review Request 122093: Install lower- and camelcase headers to different subdirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122093/ --- (Updated Jan. 19, 2015, 11:32 a.m.) Status -- This change has been m

Review Request 122140: Support reading IconPixmap and IconMask from WM_HINTS in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122140/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D

Re: Review Request 122086: Add new method KWindowSystem::icons

> On Jan. 16, 2015, 12:47 p.m., David Edmundson wrote: > > src/kwindowsystem_x11.cpp, line 798 > > > > > > this className code is very different from the one in pixmap; > > > > either this won't work, or

Re: Review Request 122093: Install lower- and camelcase headers to different subdirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122093/#review74293 --- Ship it! Let's see. This is a namespaced framework ("namespac

Re: Split kde-baseapps?

On Sunday 18 January 2015 14:35:53 David Narvaez wrote: > On Mon, Jan 5, 2015 at 3:27 AM, David Faure wrote: > > AFAIK there are two ways. One where you replay the history using git > > filter- branch, there's a wiki page about how to do this (iirc from Alex > > Merry). > This is up at g...@git.kd

Re: Review Request 122105: Fix KgDifficulty saving on app close

On Saturday 17 January 2015 21:48:29 Albert Astals Cid wrote: > KF5 people: Is this something worth mentioning on the porting notes or using > KSharedConfig::openConfig from a static destructor is a bit of a corner > case anyway? It's not the first time we hit this (IIRC), so yeah, it's definitely