Re: Review Request 121448: Introduce ECMAddAppIcon.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review74272 --- So, I took your latest upload as a basis and wrote: https://g

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review74271 --- I'm confused, why do the unittest changes include a change in

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review74270 --- Yes it's correct that KService merges servicetypes and mimetyp

Build failed in Jenkins: kde-baseapps_master_qt5 #205

See Changes: [faure] Ported webarchiver plugin to KF5 -- [...truncated 2543 lines...] saveDialogSize(group); ^ [ 63%] Building CXX object konqueror/src/CMakeFiles

Re: Review Request 122096: Fix build if epoxy headers are not installed to the default include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122096/ --- (Updated Jan. 18, 2015, 8:04 p.m.) Status -- This change has been ma

Re: Move thumbnail kioslave and thumbcreator service type to kio?

On Sun, Jan 18, 2015 at 9:16 AM, Bhushan Shah wrote: > Thanks, can you do the move? as I have no knowledge of how to preserve > history while doing so and stuff Coincidentially, I am transplanting a protocol into KIO right now, so I can do this move also. David E. Narvaez ___

Re: Split kde-baseapps?

On Mon, Jan 5, 2015 at 3:27 AM, David Faure wrote: > AFAIK there are two ways. One where you replay the history using git filter- > branch, there's a wiki page about how to do this (iirc from Alex Merry). This is up at g...@git.kde.org:clones/kio/narvaez/kio-about-protocol Please review everythi

Re: Move thumbnail kioslave and thumbcreator service type to kio?

On Sun, Jan 18, 2015 at 3:31 PM, David Faure wrote: > The servicetype: yes, for sure, it should be there. > > The kioslave: on one hand, we can't have all kioslaves in kio; on the other > hand, this one indeed has specific API in KIO (PreviewJob), which doesn't work > if kio_thumbnail isn't there.

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122007/ --- (Updated Jan. 18, 2015, 12:43 p.m.) Status -- This change has been m

Build failed in Jenkins: kde-baseapps_master_qt5 #204

See Changes: [faure] konqueror: ported the preloader to KF5. -- [...truncated 2076 lines...] Linking CXX shared library libkdeinit5_keditbookmarks.so [ 45%] Building CXX object dolphin/src/CMa

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122007/#review74226 --- Ship it! Ship It! - David Faure On Jan. 16, 2015, 6:14 a.m

Build failed in Jenkins: ksshaskpass_stable_qt5 #4

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [ksshaskpass_stable_

Build failed in Jenkins: ksshaskpass_stable_qt5 #3

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Move thumbnail kioslave and thumbcreator service type to kio?

On Sunday 18 January 2015 11:53:58 Bhushan Shah wrote: > Hello! > > At moment thumbnail kioslave and thumcreator servicetype is provided > by kio-extras repo. However KImageFilePreview uses thumbcreator > service type, which results in non functioning KIMageFIlePreview with > error/warning, > > K