Review Request 122096: Fix build if epoxy headers are not installed to the default include dir

2015-01-16 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122096/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2015-01-16 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/ --- (Updated Jan. 16, 2015, 11:52 nachm.) Review request for KDE Frameworks a

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Thomas Lübking
> On Jan. 16, 2015, 4:13 nachm., Thomas Lübking wrote: > > Wrt the other patches, using NETIcon over there, the requirement in KWin > > and likely libtaskbar (ie. keep this in sync): > > What do you think about extending the API by allowing to optionally feed in > > the required elements? > >

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review74164 --- Ralf, Can you update the diff rather than uploading the file?

Review Request 122093: Install lower- and camelcase headers to different subdirs

2015-01-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122093/ --- Review request for KDE Frameworks and Marco Martin. Bugs: 342899 http

Re: Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

2015-01-16 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122082/ --- (Updated Jan. 16, 2015, 6:21 p.m.) Status -- This change has been ma

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Eike Hein
> On Jan. 16, 2015, 4:13 p.m., Thomas Lübking wrote: > > Wrt the other patches, using NETIcon over there, the requirement in KWin > > and likely libtaskbar (ie. keep this in sync): > > What do you think about extending the API by allowing to optionally feed in > > the required elements? > > >

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #956

2015-01-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/#review74142 --- Wrt the other patches, using NETIcon over there, the requireme

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
> On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/ --- (Updated Jan. 16, 2015, 1:55 p.m.) Review request for KDE Frameworks. C

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #955

2015-01-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Martin Gräßlin
> On Jan. 16, 2015, 12:47 p.m., David Edmundson wrote: > > src/kwindowsystem_p.h, line 48 > > > > > > this is pure virtual and you haven't provided a win or mac > > implementation that will break the build? no,

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/#review74132 --- src/kwindowsystem_p.h

Re: OSX/CI: ark fails to build on branch frameworks

2015-01-16 Thread Raphael Kubo da Costa
Marko Käning writes: > Hi Raphael, > > On 14 Jan 2015, at 22:11 , Raphael Kubo da Costa wrote: >> Is the full build log available somewhere, preferably with `make >> VERBOSE=1'? This really smells like OS X having an older (< 3.0) version >> of libarchive in its "base" system, a more recent vers

Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D