Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122007/ --- (Updated Jan. 16, 2015, 6:14 a.m.) Review request for KDE Frameworks, Dav

Re: Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

2015-01-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122082/#review74114 --- Ship it! Ship It! - Lukáš Tinkl On Led. 16, 2015, 1:49 dop

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-15 Thread Jeremy Whiting
> On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

2015-01-15 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122082/ --- Review request for KDE Frameworks and Lukáš Tinkl. Repository: kio-extras

Build failed in Jenkins: kde-baseapps_master_qt5 #203

2015-01-15 Thread KDE CI System
See Changes: [arjunak234] Fix KUrl -> QUrl porting error [lukas] fix file dialog [lukas] fix parsing dialog geometries [arjunak234] Fix Terminal-View navigation sync issue [emmanuelpescosta099] port away from deprecated KFileItem(

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/ --- (Updated Jan. 15, 2015, 5:57 p.m.) Status -- This change has been ma

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Eike Hein
> On Jan. 15, 2015, 5:40 p.m., Gregor Mi wrote: > > First of all, thanks Eike for the quick patch. I cannot comment much on the > > coding details of your change since this is new stuff for me. But my > > apologies for introducing this inconvenience. > > > > Though I am not the maintainer but

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74095 --- Ship it! First of all, thanks Eike for the quick patch. I can

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #954

2015-01-15 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74076 --- +1 from here too ()would like people that did the change in sy

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74075 --- +1 Makes sense to me :) - Aleix Pol Gonzalez On Jan. 15, 2

Re: A KIO daemon

2015-01-15 Thread Aleix Pol
On Thu, Jan 15, 2015 at 7:25 AM, David Faure wrote: > After the discussion on https://gerrit.vesnicky.cesnet.cz/r/#/c/323/, I just > had another idea (inspired by a discussion with Alex Fiestas (iirc) long > ago)... > > We could combine the 4 kded modules installed by KIO into a single daemon, say

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74074 --- +1 from me - David Edmundson On Jan. 15, 2015, 1:24 p.m., E

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/ --- (Updated Jan. 15, 2015, 1:24 p.m.) Review request for KDE Frameworks, Pla

Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/ --- Review request for KDE Frameworks, Plasma, Martin Gräßlin, Gregor Mi, and M