Re: Required and supported Qt versions

On Tuesday, 30 December 2014 09:32:08 CEST, David Faure wrote: Ideally every released minor version since 5.2 :-) i.e. 5.2, 5.3, 5.4. Possibly even dev. Hi, the CI which is plugged into Gerrit now checks the following combinations: - Qt 5.2.1, GCC 4.8.2 (RHEL7), release mode - Qt 5.3.2, clang

Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/ --- (Updated Jan. 9, 2015, 10:34 p.m.) Status -- This change has been ma

Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/#review73643 --- Ship it! Ship It! - Martin Klapetek On Jan. 9, 2015, 8:48

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

> On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: > > do you have commit access? No, I don't. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572

Re: Review Request 120878: Remove unused header

> On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: > > I should have asked, do you have commit access or do you need someone to > > merge this? I do have commit access, but I am okay if anyone commits it too. I just had little time to do so. - Andrius da Costa --

Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121599/ --- (Updated Jan. 9, 2015, 7:34 p.m.) Review request for KDE Frameworks. Ch

Re: qca-qt5 2.1.0.1

Hi Harald, should perhaps stg like this: --- diff --git a/logical-module-structure b/logical-module-structure index a2ef4e3..14d1f94 100644 --- a/logical-module-structure +++ b/logical-module-structure @@ -294,6 +300,12 @@ "kf5-qt5": "master", "stable-kf5-qt5": "master"

OSX/CI: captivities fails to build on branch master

Linux/CI is quiet, but here on OSX/CI I see this: --- In file included from /opt/local/include/boost/intrusive/circular_slist_algorithms.hpp:24: /opt/local/include/boost/intrusive/detail/common_slist_algorithms.hpp:146:16: error: cannot use 'throw' with exceptions disabled throw;

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- (Updated Jan. 9, 2015, 5:07 p.m.) Status -- This change has been mar

Re: Review Request 121922: support stringlists as properties

> On Jan. 9, 2015, 3:01 p.m., Alex Richardson wrote: > > src/services/kplugininfo.cpp, line 535 > > > > > > AFAIK escaping ; or , with a \ should be allowed: see > > KConfigGroupPrivate::deserializeList() makin

Re: Review Request 121922: support stringlists as properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 9, 2015, 4:52 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 121922: support stringlists as properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 9, 2015, 4:50 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/#review73619 --- +1 too, maybe you want to pass the metadata as the 2nd paramet

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/#review73618 --- +1, Let maintainer give Shipit! - Bhushan Shah On Jan. 9, 2

Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- (Updated Jan. 9, 2015, 4:27 p.m.) Review request for KDE Frameworks. Ch

Review Request 121952: Make it possible to prevent a toolbar from being hidden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- Review request for KDE Frameworks. Bugs: 326713 https://bugs.kde.org/

Jenkins build is back to stable : kservice_master_qt5 #220

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- (Updated Jan. 9, 2015, 4:01 p.m.) Status -- This change has been mar

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73609 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 9, 2015, 3:

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73608 --- Ship it! Nice! - Alex Richardson On Jan. 9, 2015, 3:41 p.m

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73607 --- Ahh I was thinking the same thing yesterday, good stuff :) +1

Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Review Request 121946: Do not emit documentUrlChanged during reload.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121946/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Re: Review Request 121922: support stringlists as properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review73599 --- src/services/kplugininfo.cpp

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

> On Jan. 8, 2015, 3:26 p.m., Milian Wolff wrote: > > While better than before, I still don't like it very much. As soon as > > another $type-property is added, we'd need to patch this here. Imo, it just > > shows that desktop2json should be deprecated and people should start > > writing .json

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:29 p.m.) Status -- This change has been mar

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73585 --- Ship it! OK I guess this is better for future extensibility.

Re: Qt 5 buildability

On Friday 09 January 2015 22:41:15 Ben Cooksley wrote: > On Fri, Jan 9, 2015 at 10:32 PM, Jan Kundrát wrote: > > On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: > >> QtWebEngine won't build unless you have nss-devel installed (which it > >> complains about) but it also won't build u

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:24 p.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 121927: Update XCursor settings

> On Jan. 9, 2015, 12:37 p.m., Àlex Fiestas wrote: > > There is test for this code in kdeplatformtheme_unittest.cpp, do you think > > it will be possible to test the fallback we have for then the size is -1? > > > > Alsot, maybe checking with XCursorGetTheme that the theme has been applied > >

Re: Review Request 120878: Remove unused header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- I should have asked, do you have commit access or do you need

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- do you have commit access? - David Edmundson On Nov. 9, 201

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73571 --- src/platformtheme/khintssettings.cpp

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73570 --- Ship it! There is test for this code in kdeplatformtheme_unit

Re: KF 5.6 changelog

On Thursday 08 January 2015 17:07:40 Daniel Vrátil wrote: > On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: > > With cookies to Kai Uwe Broulik for using "CHANGELOG:" in most of his > > commits! > > The KPackage frameworks is Tier 2 and depends on KDocTools, which is also > Tier 2, wh

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73568 --- Ship it! Hmm. OK. At least all the logic is in the same file

Re: Qt 5 buildability

On Fri, Jan 9, 2015 at 10:32 PM, Jan Kundrát wrote: > On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: >> >> QtWebEngine won't build unless you have nss-devel installed (which it >> complains about) but it also won't build unless libcap-devel is >> installed (which it doesn't complai

Re: Qt 5 buildability

On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you).

Re: Re: Qt 5 buildability

On Fri, Jan 9, 2015 at 10:19 PM, Martin Gräßlin wrote: > On Friday 09 January 2015 22:14:09 Ben Cooksley wrote: >> On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley wrote: >> > Hi all, >> > >> > I'm not sure about which list is most appropriate for this, so i'm >> > sending it here. >> > It seems tha

Re: Re: Qt 5 buildability

On Friday 09 January 2015 22:14:09 Ben Cooksley wrote: > On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley wrote: > > Hi all, > > > > I'm not sure about which list is most appropriate for this, so i'm > > sending it here. > > It seems that changes from Qt 5.3 to 5.4 have introduced a series of > > hi

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 10:18 a.m.) Review request for KDE Frameworks, Àle

Re: Qt 5 buildability

On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley wrote: > Hi all, > > I'm not sure about which list is most appropriate for this, so i'm > sending it here. > It seems that changes from Qt 5.3 to 5.4 have introduced a series of > hidden dependencies. > > QtWebEngine won't build unless you have nss-dev

Re: Review Request 121927: Update XCursor settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73559 --- autotests/CMakeLists.txt