Re: Review Request 121461: Fix for bug 341773 and minor changes

> On Dec. 26, 2014, 1:44 p.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt`

Re: Review Request 121618: Better name for kdoctools translation domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121618/#review72642 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 28, 2014, 4

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

> On Dec. 28, 2014, 12:19 p.m., David Faure wrote: > > Ouch. > > > > This information *is* available, in the servicetype definition file. Why > > not try and read it from there? > > Alex Richardson wrote: > Well, it only works once these files are installed. This is probably not > be the

Re: Review Request 121712: Add install target for the KF5 Book

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121712/ --- (Updated Dec. 28, 2014, 11:58 p.m.) Review request for KDE Frameworks, Ro

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72634 --- low-level review: no need to create a QFile, use QFile::exists

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

2014-12-28 23:22 GMT+01:00 David Faure: > On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote: >> Hi, >> >> 2014-12-23 9:44 GMT+01:00 David Faure: >> > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: >> >> Fixed in >> >> >> >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97

Re: Review Request 121081: QT_WA

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/#review72633 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:27 p.m

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/ --- (Updated Dec. 28, 2014, 10:22 p.m.) Status -- This change has been m

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/ --- (Updated Dez. 28, 2014, 10:22 nachm.) Review request for KDE Frameworks a

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote: > Hi, > > 2014-12-23 9:44 GMT+01:00 David Faure: > > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: > >> Fixed in > >> > >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 > >> > >> Ooops, should I h

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On Dez. 20, 2014, 11:46 vorm., David Faure wrote: > > src/core/udsentry.cpp, line 51 > > > > > > Can you add an example, to ease the understanding of the data structure? > > > > Do I understand it corre

Re: Jenkins build became unstable: kio_master_qt5 #489

On Mon, Dec 29, 2014 at 11:15 AM, David Faure wrote: > On Sunday 28 December 2014 21:36:02 KDE CI System wrote: >> See > > Timeout. > > The test does finish in time, it's just that it spawns a kioexec process that > sleeps 3 minutes before exit

Re: Jenkins build became unstable: kio_master_qt5 #489

On Sunday 28 December 2014 21:36:02 KDE CI System wrote: > See Timeout. The test does finish in time, it's just that it spawns a kioexec process that sleeps 3 minutes before exiting. Looks like the CI waits for that, somehow... I guess I'll

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

Hi, 2014-12-23 9:44 GMT+01:00 David Faure: > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: >> Fixed in >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 >> >> Ooops, should I have pushed this through Gerrit before committing? > > Nope, that's fine, trivial fix

Jenkins build became unstable: kio_stable_qt5 #52

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_master_qt5 #489

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121618: Better name for kdoctools translation domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121618/#review72613 --- Ship it! Yep, go for it, I'll release next saturday, so you h

Re: Review Request 121618: Better name for kdoctools translation domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121618/ --- (Updated Dic. 28, 2014, 5 p.m.) Review request for KDE Frameworks, Locali

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

> On Dec. 28, 2014, 12:19 p.m., David Faure wrote: > > Ouch. > > > > This information *is* available, in the servicetype definition file. Why > > not try and read it from there? > > Alex Richardson wrote: > Well, it only works once these files are installed. This is probably not > be the

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

> On Dez. 28, 2014, 12:19 nachm., David Faure wrote: > > Ouch. > > > > This information *is* available, in the servicetype definition file. Why > > not try and read it from there? Well, it only works once these files are installed. This is probably not be the case when running kcoreaddons_des

Review Request 121712: Add install target for the KF5 Book

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121712/ --- Review request for KDE Frameworks. Repository: kf5book Description

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/#review72590 --- Ouch. This information *is* available, in the servicetype def

Re: Review Request 121461: Fix for bug 341773 and minor changes

> On Dec. 26, 2014, 8:14 a.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt`

Re: Review Request 121461: Fix for bug 341773 and minor changes

> On Dec. 26, 2014, 1:44 p.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt`

Re: Review Request 121461: Fix for bug 341773 and minor changes

> On Dec. 26, 2014, 8:14 a.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt`

Build failed in Jenkins: kf5book_master_qt5 #6

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kf5book_master_qt5] $ /bin/

Build failed in Jenkins: kf5book_master_qt5 #5

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kf5book_master_qt5] $ /bin/

Re: Build failed in Jenkins: snippetextractor_master_qt5 #1

On Sun, Dec 28, 2014 at 10:42 PM, Albert Astals Cid wrote: > snippetextractor or kcoreaddons ? Was a configuration mistake. It was actually trying to build snippetextractor, which is a component needed for kf5book. I missed a step when configuring Jenkins though (we copy jobs around quite a bit).

Re: Build failed in Jenkins: snippetextractor_master_qt5 #1

snippetextractor or kcoreaddons ? Confused me :D Cheers, Albert El Diumenge, 28 de desembre de 2014, a les 06:26:08, KDE CI System va escriure: > See > > -- > Started by user Ben Cooksley > Buil