Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-12-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/#review72347 --- MSVC2012 doesn't support default template parameters on functi

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-12-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review72345 --- MSVC2012 doesn't support default template parameters on functi

Re: [RFC] [kservice] KPluginMetadata indexing

2014-12-20 Thread David Faure
On Sunday 16 November 2014 13:31:46 Sebastian Kügler wrote: > The problem with the change detection is of course > - Which process is the one watching? > - What to do when this process is not running during plugin installation? > (User could be logged out, for example) Argh, yes, that's the kded

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-12-20 Thread David Faure
On Monday 08 December 2014 16:27:42 Jan Grulich wrote: > Hi, > > I would like to finally finish this. According to [1] I believe we satisfy > all conditions to become a framework. We also already have own bugzilla > component [2] and repository in reviewboard. There were also no objections > excep

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/#review72344 --- Ship it! Ship It! - David Faure On Nov. 1, 2014, 10:31 a.m

Re: Review Request 121079: Fix building dolphin tests on MSVC

2014-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review72341 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:26 p.m

Re: KPackage framework

2014-12-20 Thread David Faure
On Monday 10 November 2014 20:33:27 Marco Martin wrote: > On Monday 10 November 2014, Marco Martin wrote: > > * porting all the internal and api use of KPluginInfo to KPluginMetadata > > * removing all the query functionality, (since it needs > > KPluginTrader::applyConstraints) and making instead

Re: OSX/CI: lokalize fails to build on branch frameworks

2014-12-20 Thread Marko Käning
Hi David, thanks for responding. > I'm not sure the lokalize developers read kde-frameworks-devel. I am afraid they are not. > I guess they were relying on FindHUNSPELL.cmake from kdelibs 4 > which is now in extra-cmake-modules/attic/modules, i.e. it's disabled. > You or the lokalize developer

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-20 Thread Marko Käning
Hi Kevin, > Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that. I guess that test's code should then be guarded appropriately, so that it builds also on KDE CI's still being used Qt 5.3.2, right? Greets, Marko ___ Kde-frameworks-devel

Re: OSX/CI: lokalize fails to build on branch frameworks

2014-12-20 Thread David Faure
On Wednesday 19 November 2014 20:18:54 Marko Käning wrote: > Hi, > > I was giving lokalize a try on OSX/CI, but it failed, as it couldn’t locate > hunspell properly, which is installed via MacPorts on the OSX/CI system > below prefix /opt/local: > > --- > > $ port installed hunspell* > The follo

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/#review72335 --- Ship it! Looks good to me overall (for the details, you're th

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review72334 --- Ship it! Looks great to me, apart from a bit of missing docum