Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Albert Astals Cid
El Dijous, 18 de desembre de 2014, a les 20:15:52, Martin Klapetek va escriure: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and if > > the > > CMakeLists there are accurate, that will create a problem. > > We wil

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Martin Klapetek
On Fri, Dec 19, 2014 at 5:46 PM, šumski wrote: > > On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > > > i've checked your clone, and what new requirements will that bring, and > > > if the > > > CMakeLists there are acc

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread šumski
On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and > > if the > > CMakeLists there are accurate, that will create a problem. > > We will have a dependen

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Martin Klapetek
On Fri, Dec 19, 2014 at 8:36 AM, Martin Gräßlin wrote: > > > I don't get what you want to attempt to solve the circle - remove > KActionCollection dependency from KBookmarks? > Remove KActionCollection usage from KBookmarks, that will remove the dep on KXmlGui. It's used only in one single class

Re: Review Request 121595: Always return absolute paths in Kdelibs4Migration

2014-12-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121595/ --- (Updated Dec. 19, 2014, 11:58 a.m.) Status -- This change has been m

Re: Review Request 121595: Always return absolute paths in Kdelibs4Migration

2014-12-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121595/#review72297 --- Ship it! tested it on a clean system, seems to solve the issu

Review Request 121595: Always return absolute paths in Kdelibs4Migration

2014-12-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121595/ --- Review request for KDE Frameworks and Marco Martin. Repository: kcoreaddo

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-19 Thread Alex Merry
> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 121299: Add NET::OSD window type

2014-12-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review72290 --- Ping - Kai Uwe Broulik On Dez. 9, 2014, 6:16 nachm., Kai Uw

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-19 Thread Kevin Funk
On Thursday 18 December 2014 22:20:54 Marko Käning wrote: > /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistvie > wtest.cpp:91:16: error: no matching constructor for initialization of > 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model, > &KFileItemModel::itemsRemoved); ^