Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

On Thursday 18 December 2014 20:15:52 Martin Klapetek wrote: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and if > > the > > CMakeLists there are accurate, that will create a problem. > > We will have a dependency

OSX/CI: kde-baseapps fails to build on branch frameworks

/Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistviewtest.cpp:91:16: error: no matching constructor for initialization of 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model, &KFileItemModel::itemsRemoved); ^

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > i've checked your clone, and what new requirements will that bring, and if > the > CMakeLists there are accurate, that will create a problem. > We will have a dependency circle between kglobalaccel, kinit, kio and > kxmlgui. > Bah, I thin

Change in kio[master]: Add ark's "Extract Here" option to the context menu even whe...

Arjun AK has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/250 Change subject: Add ark's "Extract Here" option to the context menu even when files are of different types .. Add ark's "Extract Here" opt

Re: Review Request 121575: FindEpoxy.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- (Updated Dec. 18, 2014, 3:37 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 121448: Introduce ECMAddAppIcon.

> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121581: Plotter in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/#review72258 --- In general +1 to the idea. I think it makes more sense to have

Re: Review Request 121581: Plotter in kdeclarative

> On Dez. 18, 2014, 1:05 vorm., Aleix Pol Gonzalez wrote: > > I think it's a useful component that can end up being really useful > > elsewhere, therefore I think kdeclarative it's a good place to be. > > > > I'd say it would be better to have it in a separate qml module. IIRC, the > > idea of

Re: Baloo Framework - License Exception

On Thursday 18 December 2014 12:43:18 Vishesh Handa wrote: > On Wed, Dec 17, 2014 at 2:38 PM, Milian Wolff wrote: > > May I ask the question why Baloo should become a framework in the first > > place? > > On Windows or Mac, people won't use it anyways, no? Or is it required > > there > > for e.g.

Re: Review Request 119607: Support for ".hidden" files

> On Set. 17, 2014, 7:59 p.m., David Faure wrote: > > Thanks for the patch. A few comments: > > > > Is there any sort of spec or reference implementation for ".hidden" files? > > Are they supposed to support wildcards, for instance? > > > > Something else, it would be good to add a unittest to

Re: libnm-qt framework

On Thursday 18 December 2014 12:34:55 Jan Grulich wrote: > Hi David, > > I wanted to ask you if you could add libnm-qt to the list of frameworks in > sysadmin/release-tools/modules.git as I probably don't have access there. > Also if you could please re-check kde-build-metadata if I adjusted there

libnm-qt framework

Hi, I would like to inform you that libnm-qt (NetworkManagerQt) finally became an official framework. Git repository was moved under frameworks/libnm-qt and first release should be with KDE Frameworks 5.6.0. If you have any issues with this library you can report it under frameworks-networkman

Re: Baloo Framework - License Exception

On Wed, Dec 17, 2014 at 2:38 PM, Milian Wolff wrote: > > May I ask the question why Baloo should become a framework in the first > place? > On Windows or Mac, people won't use it anyways, no? Or is it required there > for e.g. searches in KMail? > > * Windows and Mac people should be using the sea

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 9:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Review Request 121258: Restart KDirWatch after a failed delete operation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121258/ --- (Updated Dec. 18, 2014, 9:38 a.m.) Status -- This change has been ma

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Review Request 121581: Plotter in kdeclarative

> On Dec. 18, 2014, 1:05 a.m., Aleix Pol Gonzalez wrote: > > I think it's a useful component that can end up being really useful > > elsewhere, therefore I think kdeclarative it's a good place to be. > > > > I'd say it would be better to have it in a separate qml module. IIRC, the > > idea of

Re: Review Request 121575: FindEpoxy.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/#review72229 --- find-modules/Findepoxy.cmake