Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-05 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/#review71451 --- Ship it! Ship It! - Nicolás Alvarez On Nov. 8, 2014, 7:13

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

2014-12-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/#review71449 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:18 p.m

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/#review71448 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:13 p.m

Change in kio[master]: Move various KIO KCMs from Konqueror to KF5::Kio.

2014-12-05 Thread Eike Hein (Code Review)
Eike Hein has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/200 Change subject: Move various KIO KCMs from Konqueror to KF5::Kio. .. Move various KIO KCMs from Konqueror to KF5::Kio. This brings over t

MultiPart HTTP requests

2014-12-05 Thread Aleix Pol
Hi all, Every now and then I end up having to generate MultiPart HTTP requests to implement some of those fancy HTTP API's to upload images. I know we have many implementation for this, namely one in kipi, then forked in ktp [1], one in kdevplatform reviewboard plugin, and probably some more. In f

Re: Review Request 119607: Support for ".hidden" files

2014-12-05 Thread Bruno Nova
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > > > > > Since we probably do not want to make it possible that all users of > > this class can make items "hidden",

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
> On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
> On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
> On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
> On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- For frameworks version it's actually using notifybyaudio plugi

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-12-05 Thread Christoph Feck
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 119607: Support for ".hidden" files

2014-12-05 Thread David Faure
> On Sept. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > > > > > Since we probably do not want to make it possible that all users of > > this class can make items "hidden",