Review Request 121303: detect kde4 home better in kde4 migration

2014-11-30 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121303/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 121299: Add NET::OSD window type

2014-11-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review71139 --- Please notice that override redirects are above EVERY managed

Review Request 121299: Add NET::OSD window type

2014-11-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/ --- Review request for KDE Frameworks, kwin and Martin Gräßlin. Repository: k

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Alexander Richardson
> On Nov. 30, 2014, 2:29 nachm., Milian Wolff wrote: > > src/kstandardaction.cpp, line 153 > > > > > > is the call to `setCheckable` not required anymore? b/c that is > > otherwise missing on the new patch now,

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Nov. 30, 2014, 2:29 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review71120 --- src/kstandardaction.cpp

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/#review71119 --- Using nullptr should be OK. It's supported in Visual Studio si

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/ --- (Updated Nov. 30, 2014, 2:11 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review71115 --- Add a kf5 reviewer otherwise nobody will review it. By default

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/#review71113 --- Perhaps add dfaure as reviewer. But for me seems good (after

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/#review71112 --- src/kactioncollection.h